925705 - Network cache fails to compile with logging disabled

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

14:50.44 /home/morbo/hg/mozilla-central/netwerk/cache2/CacheEntry.cpp: In member function ‘void mozilla::net::CacheEntry::AsyncOpen(nsICacheEntryOpenCallback*, uint32_t)’:
14:50.44 /home/morbo/hg/mozilla-central/netwerk/cache2/CacheEntry.cpp:163:164: error: ‘StateString’ was not declared in this scope

The problem is that CacheEntry::StateString is defined inside MOZ_LOGGING, but used all over the file without the protection of the same define. Instead, the LOG macro used is checking for PR_LOGGING.

This would probably work correctly, if CacheLog.h wouldn't contain a FORCE_PR_LOGGING which (I think) desyncs PR_LOGGING from MOZ_LOGGING.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Fix mismatched logging checks

An alternative fix would probably be to remove the FORCE_PR_LOGGING, but I'm going to assume it was put there for a reason.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 815810 [details] [diff] [review]
Patch 1. Fix mismatched logging checks

Review of attachment 815810 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab but change the macro to PR_LOG please.  That is the proper one!

Thanks for the fix!

Comment 3

[Gian-Carlo Pascutto [:gcp]]

>but change the macro to PR_LOG please. That is the proper one!

I can't make sense of what you say here. CacheLog.h seems to exist for no other reason than to define a LOG macro that wraps PR_LOG.

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #3)
> >but change the macro to PR_LOG please. That is the proper one!
> 
> I can't make sense of what you say here. CacheLog.h seems to exist for no
> other reason than to define a LOG macro that wraps PR_LOG.

#ifdef PR_LOG

is the what you want...  Get inspired by http://hg.mozilla.org/mozilla-central/annotate/211337f7fb83/netwerk/cache2/CacheStorageService.cpp#l649

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a699560fa7d3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a699560fa7d3

Comment 7

[Toady]

Still fails under PGO build under MSVC 2012 on windows x86_x64 with unresolved external symbol resulting in LNK2001 Only with logging disabled

Comment 8

[Gian-Carlo Pascutto [:gcp]]

You probably want to file a new, follow-up bug for that issue with more details.