Closed Bug 925796 Opened 6 years ago Closed 6 years ago

Defect - Missing win32 localized Metro builds due to broken bookmark creation


(Firefox for Metro Graveyard :: Build Config, defect, P1, critical)

26 Branch
Windows 8


(firefox26+ verified, firefox27 verified)

Firefox 27
Tracking Status
firefox26 + verified
firefox27 --- verified


(Reporter: whimboo, Assigned: mbrubeck)




(Whiteboard: [mozmill] feature=defect c=tbd u=tbd p=1)


(1 file)

As it can be seen on the following URL we have a lot of broken l10n builds on mozilla-aurora due to a failure in creating the bookmarks in the repack process:

Generating: bookmarks
e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\obj-firefox\browser\metro\locales\import\Makefile:52:0$ e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/ \
  -I e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/l10n/mn/browser/profile/ \
  -DAB_CD=mn \
  e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/browser/metro/locales/import/../generic/profile/ > ../bookmarks.json
e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\obj-firefox\browser\metro\locales\import\Makefile:52:0: command 'e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/ \
  -I e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/l10n/mn/browser/profile/ \
  -DAB_CD=mn \
  e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/browser/metro/locales/import/../generic/profile/ > ../bookmarks.json' failed, return code 1
evaluation from e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\config\ command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../ -C import export' failed, return code 2
e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\config\ command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../ export' failed, return code 2
e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\obj-firefox\browser\locales\Makefile:149:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../ -C ../metro/locales AB_CD=mn XPI_NAME=locale-mn' failed, return code 2
Traceback (most recent call last):
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 492, in <module>
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 477, in main
    pp.handleCommandLine(None, True)
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 169, in handleCommandLine
    self.do_include(f, False)
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 462, in do_include
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 241, in handleLine
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 139, in write
    filteredLine = self.applyFilters(aLine)
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 124, in applyFilters
    aLine = f[1](aLine)
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 420, in filter_substitution
    return self.varsubst.sub(repl, aLine)
  File "e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/config/", line 418, in repl
    raise Preprocessor.Error(self, 'UNDEFINED_VAR', varname)
__main__.Error: ('e:\\builds\\moz2_slave\\m-aurora-w32-l10n-ntly-0000000\\build\\mozilla-aurora\\browser\\metro\\locales\\generic\\profile\\', 3, 'UNDEFINED_VAR', 'bookmarks_title')
program finished with exit code 2

Some affected locales are: ta-LK, ur, mn, hi-IN,
Component: General Automation → Build Config
Product: Release Engineering → Core
QA Contact: catlee
Version: other → 26 Branch
This is a metro build issue, moving over.

The problem is that the l10n-merge deps in browser/metro/locales/import are wrong.

Currently, it's

vpath $(LOCALE_SRCDIR)/profile
vpath $(LOCALE_SRCDIR)/profile
vpath @top_srcdir@/$(relativesrcdir)/en-US/profile

but it needs to mimic what we do for desktop

vpath $(LOCALE_MERGEDIR)/browser/profile
vpath $(LOCALE_SRCDIR)/profile
vpath @srcdir@/en-US/profile

The full complexity of the double ifdef is required.
Product: Core → Firefox for Metro
Marco - can you get someone on this?
Assignee: nobody → mmucci
Summary: Missing win32 localized builds due to broken bookmark creation → Defect - Missing win32 localized builds due to broken bookmark creation
Whiteboard: [mozmill] → [mozmill] [triage] feature=defect c=tbd u=tbd p=0
Summary: Defect - Missing win32 localized builds due to broken bookmark creation → Defect - Missing win32 localized Metro builds due to broken bookmark creation
OS: Windows 7 → Windows 8
I'm bumping the importance of this because Windows is our #1 platform, and Aurora is where localizers do their work. We're getting close to the next uplift, and it's important for localizers to be able to verify their work.
Severity: major → critical
Attached patch patchSplinter Review
This patch just implements Pike's fix from comment 2.
Assignee: mmucci → mbrubeck
Attachment #817285 - Flags: review?(gps)
QA Contact: jbecerra
Whiteboard: [mozmill] [triage] feature=defect c=tbd u=tbd p=0 → [mozmill] feature=defect c=tbd u=tbd p=0
Blocks: metrov1it17
No longer blocks: metrov1backlog
Whiteboard: [mozmill] feature=defect c=tbd u=tbd p=0 → [mozmill] feature=defect c=tbd u=tbd p=1
Priority: -- → P1
Attachment #817285 - Flags: review?(gps) → review+
Backed out along with bug 923596 because one of them caused Metro to crash/hang:
Comment on attachment 817285 [details] [diff] [review]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): enabling Metro on Aurora

User impact if declined: broken l10n repacks on Aurora

Testing completed (on m-c, etc.): landed on fx-team; green on TBPL

Risk to taking this patch (and alternatives if risky): this is a Metro-only change that should only affect Metro localization.

String or IDL/UUID changes made by this patch: None.
Attachment #817285 - Flags: approval-mozilla-aurora?
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Attachment #817285 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
catlee mailed me this:

I've been working on a 26.0b1 staging release for the past week. Just wanted to check that these issues were on your radar:

ta-LK seems to be missing bookmarks_title for metro?
__main__.Error: ('e:\\builds\\moz2_slave\\rel-m-beta-w32_rpk_6-000000000\\mozilla-beta\\browser\\metro\\locales\\generic\\profile\\', 3, 'UNDEFINED_VAR', 'bookmarks_title')

mn also:
__main__.Error: ('e:\\builds\\moz2_slave\\rel-m-beta-w32_rpk_4-000000000\\mozilla-beta\\browser\\metro\\locales\\generic\\profile\\', 3, 'UNDEFINED_VAR', 'bookmarks_title') 

Chris, can you check that you have the fix of this bug in your staging test?
No, I don't have that fix. I started the staging release prior to it landing. Do I need to re-build the en-US builds, or can I just transplant that fix and re-run my repacks?
I suspect you need to rebuild en-US, as repacks update to the en-US revision to make merge-l10n work, and that's where the culprit is.
While testing this for iteration #17, with the ur Aurora build from on Win 8 64-bit, it works in Metro mode: I did a little browsing and added some bookmarks.

Is there anything else QA should cover, in order to verify this bug? Thanks!
Flags: needinfo?(mbrubeck)
Nope, I think that's good.
Flags: needinfo?(mbrubeck)
It's all fine now, yes! There are no more such failures listed at:
You need to log in before you can comment on or make changes to this bug.