Closed Bug 923596 Opened 6 years ago Closed 6 years ago

Integrate Shumway code into Metro Firefox (disabled by default)

Categories

(Firefox for Metro Graveyard :: Components, enhancement)

All
Windows 8.1
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This adds support for the Shumway extension (JavaScript/HTML player for SWF) to Metro Firefox -- disabled by default for now, as it is in desktop Firefox.
Attachment #813680 - Flags: review?(jmathies)
Attachment #813680 - Flags: review?(gps)
Attachment #813680 - Flags: feedback?(ydelendik)
No longer depends on: 812358
Comment on attachment 813680 [details] [diff] [review]
patch

Review of attachment 813680 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on metro specific changes.

::: browser/metro/base/content/browser-ui.js
@@ +111,5 @@
>      PageThumbs.init();
>      NewTabUtils.init();
>      SettingsCharm.init();
>      NavButtonSlider.init();
> +    ShumwayUtils.init();

do we need to call this if it's not enabled via prefs?
Attachment #813680 - Flags: review?(jmathies) → review+
Touch events simulation is not implemented atm, see https://github.com/mozilla/shumway/issues/767 . So it might be a problem, similar to the bug 859579
(In reply to Jim Mathies [:jimm] from comment #1)
> > +    ShumwayUtils.init();
> 
> do we need to call this if it's not enabled via prefs?

Yes -- calling it adds a pref observer, so that toggling the pref via about:config will enable the add-on.

(In reply to Yury Delendik (:yury) from comment #2)
> Touch events simulation is not implemented atm, see
> https://github.com/mozilla/shumway/issues/767 . So it might be a problem,
> similar to the bug 859579

Yes, I think we should block on good touch support before enabling Shumway by default.  But many Windows 8 users have mouse or trackpad instead of (or in addition to) touch, so it will still be easy for most users to test Shumway in Metro.
Comment on attachment 813680 [details] [diff] [review]
patch

Review of attachment 813680 [details] [diff] [review]:
-----------------------------------------------------------------

Reluctant r+ because of poor makeisms. But it's no worse than what's already in this Makefile.in
Attachment #813680 - Flags: review?(gps) → review+
Attachment #813680 - Flags: feedback?(ydelendik)
Backed out along with bug 925796 because one of them caused Metro to crash/hang:
https://hg.mozilla.org/integration/fx-team/rev/5ec2fca2c0b0
Depends on: 926988
Pushed to Try to find out whether this still breaks our test automation:
https://tbpl.mozilla.org/?tree=Try&rev=c17feef46411
Fixed the failure by adding a missing change to the package manifest:
https://tbpl.mozilla.org/?tree=Try&rev=faed35a5ca67

Updated to latest trunk and landed on fx-team:
https://hg.mozilla.org/integration/fx-team/rev/6370458acfd9
Depends on: 952844
This was merged a while ago but wasn't resolved due to oversight.
https://hg.mozilla.org/mozilla-central/rev/6370458acfd9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Blocks: 936907
No longer blocks: 936907, shumway
No longer depends on: 952844
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.