Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Integrate Shumway code into Metro Firefox (disabled by default)

RESOLVED FIXED in Firefox 29

Status

Firefox for Metro
Components
--
enhancement
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Trunk
Firefox 29
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 813680 [details] [diff] [review]
patch

This adds support for the Shumway extension (JavaScript/HTML player for SWF) to Metro Firefox -- disabled by default for now, as it is in desktop Firefox.
Attachment #813680 - Flags: review?(jmathies)
Attachment #813680 - Flags: review?(gps)
Attachment #813680 - Flags: feedback?(ydelendik)
No longer depends on: 812358

Comment 1

4 years ago
Comment on attachment 813680 [details] [diff] [review]
patch

Review of attachment 813680 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on metro specific changes.

::: browser/metro/base/content/browser-ui.js
@@ +111,5 @@
>      PageThumbs.init();
>      NewTabUtils.init();
>      SettingsCharm.init();
>      NavButtonSlider.init();
> +    ShumwayUtils.init();

do we need to call this if it's not enabled via prefs?
Attachment #813680 - Flags: review?(jmathies) → review+
Touch events simulation is not implemented atm, see https://github.com/mozilla/shumway/issues/767 . So it might be a problem, similar to the bug 859579
(Assignee)

Comment 3

4 years ago
(In reply to Jim Mathies [:jimm] from comment #1)
> > +    ShumwayUtils.init();
> 
> do we need to call this if it's not enabled via prefs?

Yes -- calling it adds a pref observer, so that toggling the pref via about:config will enable the add-on.

(In reply to Yury Delendik (:yury) from comment #2)
> Touch events simulation is not implemented atm, see
> https://github.com/mozilla/shumway/issues/767 . So it might be a problem,
> similar to the bug 859579

Yes, I think we should block on good touch support before enabling Shumway by default.  But many Windows 8 users have mouse or trackpad instead of (or in addition to) touch, so it will still be easy for most users to test Shumway in Metro.

Comment 4

4 years ago
Comment on attachment 813680 [details] [diff] [review]
patch

Review of attachment 813680 [details] [diff] [review]:
-----------------------------------------------------------------

Reluctant r+ because of poor makeisms. But it's no worse than what's already in this Makefile.in
Attachment #813680 - Flags: review?(gps) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/00a62ede0d4d
(Assignee)

Updated

4 years ago
Attachment #813680 - Flags: feedback?(ydelendik)
(Assignee)

Comment 6

4 years ago
Backed out along with bug 925796 because one of them caused Metro to crash/hang:
https://hg.mozilla.org/integration/fx-team/rev/5ec2fca2c0b0

Updated

4 years ago
Depends on: 926988
(Assignee)

Comment 7

4 years ago
Pushed to Try to find out whether this still breaks our test automation:
https://tbpl.mozilla.org/?tree=Try&rev=c17feef46411
(Assignee)

Comment 8

4 years ago
Fixed the failure by adding a missing change to the package manifest:
https://tbpl.mozilla.org/?tree=Try&rev=faed35a5ca67

Updated to latest trunk and landed on fx-team:
https://hg.mozilla.org/integration/fx-team/rev/6370458acfd9
(Assignee)

Updated

4 years ago
Depends on: 952844
(Assignee)

Comment 9

4 years ago
This was merged a while ago but wasn't resolved due to oversight.
https://hg.mozilla.org/mozilla-central/rev/6370458acfd9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
(Assignee)

Updated

4 years ago
Blocks: 936907
(Assignee)

Updated

4 years ago
Blocks: 967306
(Assignee)

Updated

4 years ago
No longer blocks: 936907, 904346
No longer depends on: 952844
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.