Closed Bug 925803 Opened 7 years ago Closed 7 years ago

Fix bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format.

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.24

People

(Reporter: philip.chee, Assigned: neil)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 717490 removed support for importing from the legacy signons.txt format and for legacy logins "encrypted" with base64.
Attached patch Temporary bustage fix. (obsolete) — Splinter Review
Band aid to get SM to compile sucessfully. Importing signon*.txt files are still broken though
Attachment #815915 - Flags: feedback?(neil)
Bug 925489 covers this for Thunderbird, where apparently only the tests are affected which are still using these mechanism for simplicity.
Comment on attachment 815915 [details] [diff] [review]
Temporary bustage fix.

Neil is working on a comprehensive fix. Cancelling this patch.
Attachment #815915 - Attachment is obsolete: true
Attachment #815915 - Flags: feedback?(neil)
Summary: Band-aid to fix immediate bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format. → Fix bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format.
Duplicate of this bug: 925919
Attached patch Proposed patchSplinter Review
In theory this should mean that we start importing passwords from Thunderbird 3+ (which I don't think we were doing).
Assignee: philip.chee → neil
Status: NEW → ASSIGNED
Attachment #816164 - Flags: review?(philip.chee)
Attachment #816164 - Flags: review?(iann_bugzilla)
Attachment #816164 - Flags: review?(bugzilla)
Depends on: 918853
Attachment #816164 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset e5bc57cec090.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.24
Comment on attachment 816164 [details] [diff] [review]
Proposed patch

r=me
Attachment #816164 - Flags: review?(philip.chee) → review+
Comment on attachment 816164 [details] [diff] [review]
Proposed patch

I'm quite sure I reviewed this, but forgot to mark it as such :) (I remember testing the patch). Anyway, bug fixed, review request obsolete.
Attachment #816164 - Flags: review?(bugzilla)
You need to log in before you can comment on or make changes to this bug.