Fix bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format.

RESOLVED FIXED in seamonkey2.24

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philip.chee, Assigned: neil)

Tracking

Trunk
seamonkey2.24

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

11.23 KB, patch
philip.chee
: review+
iann_bugzilla
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
Bug 717490 removed support for importing from the legacy signons.txt format and for legacy logins "encrypted" with base64.
(Reporter)

Comment 1

6 years ago
Posted patch Temporary bustage fix. (obsolete) — Splinter Review
Band aid to get SM to compile sucessfully. Importing signon*.txt files are still broken though
Attachment #815915 - Flags: feedback?(neil)

Comment 2

6 years ago
Bug 925489 covers this for Thunderbird, where apparently only the tests are affected which are still using these mechanism for simplicity.
(Reporter)

Comment 3

6 years ago
Comment on attachment 815915 [details] [diff] [review]
Temporary bustage fix.

Neil is working on a comprehensive fix. Cancelling this patch.
Attachment #815915 - Attachment is obsolete: true
Attachment #815915 - Flags: feedback?(neil)
(Reporter)

Updated

6 years ago
Summary: Band-aid to fix immediate bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format. → Fix bustage caused by Bug 717490 removing support for importing logins from legacy signons.txt format.
(Reporter)

Updated

6 years ago
Duplicate of this bug: 925919
(Assignee)

Comment 5

6 years ago
In theory this should mean that we start importing passwords from Thunderbird 3+ (which I don't think we were doing).
Assignee: philip.chee → neil
Status: NEW → ASSIGNED
Attachment #816164 - Flags: review?(philip.chee)
Attachment #816164 - Flags: review?(iann_bugzilla)
Attachment #816164 - Flags: review?(bugzilla)
(Reporter)

Updated

6 years ago
Depends on: 918853

Updated

6 years ago
Attachment #816164 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 6

6 years ago
Pushed comm-central changeset e5bc57cec090.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.24
(Reporter)

Comment 7

6 years ago
Comment on attachment 816164 [details] [diff] [review]
Proposed patch

r=me
Attachment #816164 - Flags: review?(philip.chee) → review+
Comment on attachment 816164 [details] [diff] [review]
Proposed patch

I'm quite sure I reviewed this, but forgot to mark it as such :) (I remember testing the patch). Anyway, bug fixed, review request obsolete.
Attachment #816164 - Flags: review?(bugzilla)
You need to log in before you can comment on or make changes to this bug.