925892 - add "channel=sb" parameter to Google plugin to distinguish search bar searches

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Currently search bar searches cannot easily be distinguished from the others, apart from "lack of a 'channel' param". It would be better for that to be more explicit.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This adds a channel=sb parameter to searches triggered by our search bar.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 816046 [details] [diff] [review]
patch

Review of attachment 816046 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/searchplugins/google.xml
@@ +25,5 @@
>  #endif
>    <MozParam name="channel" condition="purpose" purpose="contextmenu" value="rcs"/>
>    <MozParam name="channel" condition="purpose" purpose="keyword" value="fflb"/>
>    <MozParam name="channel" condition="purpose" purpose="homepage" value="np"/>
> +  <MozParam name="channel" condition="purpose" purpose="searchbar" value="sb"/>

Nit: s/searchbar/searchbox/ throughout the changes.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=46836e970196

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 816110 [details] [diff] [review]
patch

Review of attachment 816110 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about changing my mind but after seeing that FHR is already using "searchbar" and it's also the id of the binding I guess we should be consistent. r=me with the change.

While reviewing this patch, I found that the command line search argument is a remaining getSubmission call without a purpose argument. I filed bug 925967 to add a purpose and start warning when one is missing.

Comment 6

[Mike Connor [:mconnor]]

I don't think it makes sense to send the extra seven characters on billions of requests to be consistent with our internal code.  =sb is what we should use in this case, unless Google says otherwise.

Comment 7

[Matthew N. [:MattN]]

(In reply to Mike Connor [:mconnor] from comment #6)
> I don't think it makes sense to send the extra seven characters on billions
> of requests to be consistent with our internal code.  =sb is what we should
> use in this case, unless Google says otherwise.

"sb" is what gets sent in the URL. The internal purpose argument maps to a value provided by the search engine. See the snippet in comment 2.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Joanne, can you confirm that we're clear to make this change on Nightly (i.e. that it won't cause any trouble on Google's end)?

Comment 9

[Joanne Nagel]

I have shared the information with Google and just waiting for confirmation that this will not be an issue on their end.  Thanks, Joanne

Comment 10

[Joanne Nagel]

Hi Gavin, Google's technical team has confirmed the channel "sb".  Once you have a timeline that I can share with them, could you let me know?  Thanks, Joanne

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/19b5c3b11c94

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19b5c3b11c94