925990 - Profile has pink text on top of it

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Tom Herold]

Attachment: screenshot.jpg

I am using nightly 27.0a1 from 23/10/11.

When I record a profile the "graph" gets overdrawn with Pink text saying: [Object Object]. Anton checked out and rules out addons/extensions and probably some other stuff. (ask him personally)

See the attached screenshot.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I'm going to look into this.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

This is caused by bug 867757 which changed markers to be objects instead of strings, and bug 918825 has increased the number of such markers. I don't think displaying the markers in the graph makes sense any longer, especially when you zoom in a particular area of the graph, where the text just looks stretched and ugly.

What I'd like to see is these events to appear as vertical bars with different colors per category/type and display a legend somewhere that explains what each color stands for. Maybe even show tooltips when hovering over these bars. I'm not sure how far the profiler UI rewrite has progressed though, and whether it makes sense to do this in Cleopatra.

Comment 3

[Benoit Girard (:BenWa)]

We've changed how markers are displayed in our repo to be much nicer. You should by default hide non text markers.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Ignore non-string markers

Benoit, you mean like this? Which markers are going to be plain strings?

I tried to just use marker.name, but the display was too cluttered even with the right labels and zooming in needs more work as it still results in ugly text.

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 822307 [details] [diff] [review]
Ignore non-string markers

Going forward all markers will an object. Maybe you want to do it if the type is tracing.

http://mxr.mozilla.org/mozilla-central/source/tools/profiler/ProfilerMarkers.cpp#71

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Don't display markers in the profile graph v2

OK, in that case I think the best short-term solution is to not display markers altogether. Displaying them properly can be done after the UI rewrite.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/60c2fea83c0f

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/60c2fea83c0f