Search results with lengthy names cause overlap issues

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: krupa.mozbugs, Assigned: amirn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 816161 [details]
screenshot.png

build: 1.2 on unagi from Oct 11th (https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-aurora-unagi-eng/latest/)
device: Unagi

steps to reproduce:
1. Search for Dictionary in the e.me search box
2. Notice that the marketplace app 'Dictionary (by Dictionary.com)' is among the search results
3. Notice how the app underneath (urban dictionary) is pushed down causing the app icon to partially overlap with the app name.

observed behavior:
Search results with lengthy names cause alignment issues in the grid resulting in overlap of the app icon with the app name. See screenshot
Assignee: nobody → amirn
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 8337758 [details] [review]
Redirect to PR
Attachment #8337758 - Flags: review?(ran)
Attachment #8337758 - Flags: review?(evyatar)
Amir, the removal of <li> css height causes the separator to "jump" a few times before the items above have fully rendered.
Comment on attachment 8337758 [details] [review]
Redirect to PR

r+, but see ran's comment 2.

Also I suggest moving all those values to a single place (be it Utils or Result.js), but it's not critical.
https://github.com/mozilla-b2g/gaia/pull/14020/files?w=1#diff-2a0d8bf37d05354a2469f5d3ffd03aa5R5
Attachment #8337758 - Flags: review?(evyatar) → review+
(Assignee)

Comment 4

5 years ago
thanks guys. updated PR.
Comment on attachment 8337758 [details] [review]
Redirect to PR

Looking good
Attachment #8337758 - Flags: review?(ran) → review+
(Assignee)

Comment 6

5 years ago
landed
Status: ASSIGNED → RESOLVED
blocking-b2g: --- → 1.3?
Last Resolved: 5 years ago
Resolution: --- → FIXED
Clearing nom - this is already part of 1.3, so this doesn't need to be triaged.
blocking-b2g: 1.3? → ---
You need to log in before you can comment on or make changes to this bug.