926479 - Replace className comparisons with classList.contains in SideMenuWidget.jsm

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #926477 +++

+++ This bug was initially created as a clone of Bug #926471 +++

See the following search for each instance of this: http://mxr.mozilla.org/mozilla-central/search?string=.className+%3D%3D&find=SideMenuWidget.jsm&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

If someone adds a new className to the element, these checks will fail. They should instead be using .classList.contains().

Comment 1

[rtnpro]

I'd love to work on it. I saw the code here http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/SideMenuWidget.jsm#170 and the fix looks trivial. However, I'd like to setup my devel environment first and test the fix that I have thought of.

Thanks :)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Great! After you get a patch written and tested, then you can attach the patch to this bug and set the review flag to '?' and put in :robcee as the reviewer.

Comment 3

[rtnpro]

Attachment: patch to replace className comparisons with classList.contains()

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f05da065e7af

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f05da065e7af

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Congratulations on your first patch!