926587 - [B2G][Clock][Stopwatch] Choppy transition animation going to Stopwatch from Timer or Alarm

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[gbennett]

Description:
Transitioning to Stopwatch from Alarm or Timer is choppy and could use some polish as it does not match going vice versa.

Repro Steps:
1) Updated Buri 1.3 mozRIL to BuildID: 20131014040204
2) Open clock app
3) Go between selecting stopwatch and timer

Actual:
Choppy tranition animation occurs.

Expected:
Animation matches going to Timer and Alarm (smooth).

Environmental Variables:
Device: Buri 1.3 mozRIL
BuildID: 20131014040204
Gaia: f240abf567325d486c3d0434791b1d132cfa327a
Gecko: 211337f7fb83
Version: 27.0a1
Firmware Version: 20130912

Repro frequency: 100%, 7/7
See attached: http://www.youtube.com/watch?v=8buU3F99kwk

Comment 1

[Jason Smith [:jsmith]]

Is this a recent regression?

Comment 2

[gbennett]

This also occurs when going between Alarm and Timer tabs as well.

Comment 3

[sarsenyev]

The "Stopwatch" is a pretty new future.
All 1.3 builds are affected
after testing throughout a couple builds on Buri device, the issue on 1.2 Aurora builds occurs as well.
Was unable to test on the first Buri V1.3 central build, since the build is broken for me.
Here is variables with the earlier builds

Device: Buri v1.3 Mozilla RIL
BuildID: 20130919040201
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 803189f35921
Version: 27.0a1
Firmware revision: US_20130912

Device: Buri v1.2 Aurora Mozilla RIL
BuildID: 20130918004001
Gaia: 9b1b262e8fde58be453fb05ed91c0e93ab86d394
Gecko: 0322470077b7
Version: 26.0a2

Comment 4

[Mike Pennisi [:jugglinmike]]

This has been caused by a regression in the b2g platform. I created Bug 921317 to report that regression and track its resolution.

Because the time frame for the resolution of that bug is unclear, we are going to implement a sub-optimal and application-specific workaround for Clock.

Comment 5

[Corey Frang [:gnarf]]

Attachment: patch v1

Comment 6

[Corey Frang [:gnarf]]

P.S. - I updated the commit message to be the title of this bug instead on my local branch - forgot to do that before i uploaded it.

Comment 7

[Mike Pennisi [:jugglinmike]]

Comment on attachment 820528 [details] [diff] [review]
patch v1

Review of attachment 820528 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for implementing this, Corey! I'll ask you to land this, since your local copy of the commit has the correct message.

Comment 8

[Corey Frang [:gnarf]]

master: https://bugzilla.mozilla.org/show_bug.cgi?id=926587

Comment 9

[Corey Frang [:gnarf]]

cough- paste fail...

master: https://github.com/mozilla-b2g/gaia/commit/af77086d88d66ba75dc040e4cd2fa6990be2b0bf

Comment 10

[Dylan Oliver [:doliver]]

triage: koi+ for this bug (and blocking bug 916996) based on the plan laid out in https://bugzilla.mozilla.org/show_bug.cgi?id=921317#c29

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a72ba0694d2a

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted af77086d88d66ba75dc040e4cd2fa6990be2b0bf to:
v1.2: 21eb34da25e99db791f21ce4b06c891cecc7fd97

Comment 13

[William Hsu [:whsu]]

Thanks! Verified it.

* Test Build:
 - Gaia:     04ee9e4430b25ba2c38752d3897f0ee5e2a6ab80
 - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/52f24889dccc
 - BuildID   20131027004003
 - Version   26.0a2

Attaching the video.

Comment 14

[Tony Nguyen]

Changing tracking flag to verified based on comment 13.

Comment 15

[Corey Frang [:gnarf]]

Reverted commit in favor of a real fix now: 

revert: https://github.com/mozilla-b2g/gaia/commit/e58b3cdec712e34e28d434caa59238c88b481b2d

Real fix is in bug 926587 / 87a3467f0a36678f36007ef5b1dc10a6708f21f2 on master

Comment 16

[Corey Frang [:gnarf]]

Sorry -- I meant to say bug 921317