926606 - WebAudio: "ASSERTION: Slice out of range" (MediaSegment::AppendSliceInternal) with feedback cycle

Status: RESOLVED WORKSFORME

(Core :: Web Audio, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Slice out of range: 'aStart >= 0 && aEnd <= aSource.mDuration', file content/media/MediaSegment.h, line 260

Comment 1

[Maire Reavy [:mreavy]]

Karl, can you look at this?

Comment 2

[Maire Reavy [:mreavy]]

Moving to Paul per our meeting yesterday.

Comment 3

[Paul Adenot (:padenot)]

Note to self: this web audio graph has no input.

Comment 4

[Paul Adenot (:padenot)]

I can't repro anymore, I'll assume roc's big patch on MediaStreamSourceNode has fixed it. Feel free to reopen if you can still repro.

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: v2.html

I'm guessing the testcase no longer fails because the fix for bug 898291 meant that the PannerNode now outputs null chunks until it gets non-null input.

Modifying the testcase to have sounds restores the assertion failure.

Comment 6

[Jesse Ruderman]

Still happens on mozilla-central. Now fatal:

Assertion failure: aStart >= 0 && aEnd <= aSource.mDuration (Slice out of range), at /builds/slave/m-cen-osx64-d-0000000000000000/build/media/webrtc/signaling/../../../content/media/MediaSegment.h:295

There are also a lot of intermittent-failure bugs mentioning this assertion failure.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Just tried to repro on a debug linux build; no problems in multiple reloads.  Perhaps resolved (bug 848954?) or perhaps mac-only?  Or just fixed along the way in the last 5 months?

Comment 8

[Jesse Ruderman]

I can't reproduce (testcase v2 on Mac). Karl, can you still reproduce?

Comment 9

[Karl Tomlinson (:karlt)]

I can't reproduce.  I don't know that the core issue is fixed because the TrackUnionStream from createMediaStreamDestination does not use the InMutedCycle() logic.  Perhaps changes from bug 932400 happened to change the stream ordering or perhaps changes from bug 1061046 mean TrackUnionStream is coping better.