Closed
Bug 926722
Opened 11 years ago
Closed 11 years ago
Simplify Scratchpad's writeAsErrorComment
Categories
(DevTools Graveyard :: Scratchpad, defect, P3)
DevTools Graveyard
Scratchpad
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: bbenvie, Assigned: bbenvie)
References
Details
Attachments
(1 file)
|
4.50 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Once bug 812764 lands it will be possible to remove some of the code from writeAsErrorComment. It will be possible to simply use getPrototypeAndProperties instead of also manually getting each of the four properties.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Removes the manual cranking the wheel to get all the properties since bug 812624 was fixed.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 817954 [details] [diff] [review]
bug-926722.patch
https://tbpl.mozilla.org/?tree=Try&rev=3d13261ccf8f
Attachment #817954 -
Flags: review?(rcampbell)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 817954 [details] [diff] [review]
bug-926722.patch
Review of attachment 817954 [details] [diff] [review]:
-----------------------------------------------------------------
presumably this passes all tests. Looks cleaner.
::: browser/devtools/scratchpad/scratchpad.js
@@ +666,4 @@
> }
>
> return deferred.promise.then(aMessage => {
> + console.error(aMessage);
good idea.
Attachment #817954 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•