Closed Bug 926722 Opened 7 years ago Closed 7 years ago

Simplify Scratchpad's writeAsErrorComment

Categories

(DevTools Graveyard :: Scratchpad, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: bbenvie, Assigned: bbenvie)

References

Details

Attachments

(1 file)

Once bug 812764 lands it will be possible to remove some of the code from writeAsErrorComment. It will be possible to simply use getPrototypeAndProperties instead of also manually getting each of the four properties.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Attached patch bug-926722.patchSplinter Review
Removes the manual cranking the wheel to get all the properties since bug 812624 was fixed.
Comment on attachment 817954 [details] [diff] [review]
bug-926722.patch

Review of attachment 817954 [details] [diff] [review]:
-----------------------------------------------------------------

presumably this passes all tests. Looks cleaner.

::: browser/devtools/scratchpad/scratchpad.js
@@ +666,4 @@
>      }
>  
>      return deferred.promise.then(aMessage => {
> +      console.error(aMessage);

good idea.
Attachment #817954 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/ffe975c3e914
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.