926722 - Simplify Scratchpad's writeAsErrorComment

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P3)

Description

[Brandon Benvie [:benvie]]

Once bug 812764 lands it will be possible to remove some of the code from writeAsErrorComment. It will be possible to simply use getPrototypeAndProperties instead of also manually getting each of the four properties.

Comment 1

[Brandon Benvie [:benvie]]

Attachment: bug-926722.patch

Removes the manual cranking the wheel to get all the properties since bug 812624 was fixed.

Comment 2

[Brandon Benvie [:benvie]]

Comment on attachment 817954 [details] [diff] [review]
bug-926722.patch

https://tbpl.mozilla.org/?tree=Try&rev=3d13261ccf8f

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 817954 [details] [diff] [review]
bug-926722.patch

Review of attachment 817954 [details] [diff] [review]:
-----------------------------------------------------------------

presumably this passes all tests. Looks cleaner.

::: browser/devtools/scratchpad/scratchpad.js
@@ +666,4 @@
>      }
>  
>      return deferred.promise.then(aMessage => {
> +      console.error(aMessage);

good idea.

Comment 4

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/ffe975c3e914

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ffe975c3e914