926798 - IME support for e10s

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Makoto Kato [:m_kato]]

When turning on e10s, IME on content doesn't works on Windows nightly build.  Of course, it works on chrome (ex. address bar)

GetDesiredIMEState() always returns IMEState::DISABLE on e10s, so nsIMEStateManager::GetNewIMEState turns off IME state.

nsIMEStateManaber should query content process for IME state.

Comment 1

[Makoto Kato [:m_kato]]

Also, before IME_START_COMPOSITION, NS_QUERY_SELECTED_TEXT is called.  So when calling it, GetIMETabParent is still null.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: always use CROSS_IME

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Part 2. Allow default constructor of IME event for IPDL

IPDL generates default constructor for IPC.  So we should remove MOZ_CRASH for it.

Comment 4

[Makoto Kato [:m_kato]]

TODO:
IME requires NS_QUERY_TEXT_RECT and NS_QUERY_CARET_RECT for content process (TabParent)

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 818171 [details] [diff] [review]
always use CROSS_IME

Always use MOZ_CROSS_PROCESS_IME.

Comment 6

[Makoto Kato [:m_kato]]

After this, user can input text via IME.  But candidate window may be wrong position.   Bug 935821 will fix this issue.

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 818171 [details] [diff] [review]
always use CROSS_IME

Bill, can you please Makoto's IME changes?

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 818171 [details] [diff] [review]
always use CROSS_IME

Review of attachment 818171 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks very much for working on this! It looks like bug 835591 disabled this stuff because it makes b2g startup slower. So I think it would be better to put this at the top of the file instead:

#ifndef MOZ_B2G
#define MOZ_CROSS_PROCESS_IME
#endif

Also, I think :roc would be a good reviewer for this code in the future.

Comment 9

[Makoto Kato [:m_kato]]

Attachment: deinfe MOZ_CROSS_PROCESS_IME for non-B2G

MOZ_CROSS_PROCESS_IME is required for e10s IME

But, comment #8 by billm, defined MOZ_CROSS_PROCESS_IME is performance problem on B2G, so MOZ_CROSS_PROCESS_IME is only defined on non-B2G build

Comment 10

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1168eb4503

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c1168eb4503