927254 - Purge the Skia texture cache when there is a memory-pressure event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Nicholas Nethercote [inactive]]

From bug 918978 comment 23:

> Another thing we need to do is purge the Skia texture cache entirely when there is a
> memory-pressure event. I had a patch for this a while back but I have no idea what I
> did with it.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Purge SkiaGL texture cache on memory pressure

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/428bea088d2b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1b82e113f85e for breaking the build like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=29944884&tree=Mozilla-Inbound

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Also broke ASAN debug, if that helps with fixing it: https://tbpl.mozilla.org/php/getParsedLog.php?id=29945242&tree=Mozilla-Inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Basically was busted on all debug builds for the same reason.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

I guess that's what I get for committing copy/pasted code at 11pm. Sorry. Repushed with fix:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4cccf4390c6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4cccf4390c6

Comment 8

[Sotaro Ikeda [:sotaro]]

From Bug 936285 Comment 18, this fix needs to uplift to b2g v1.2.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> From Bug 936285 Comment 18, this fix needs to uplift to b2g v1.2.

Okay. Blocks a blocker then.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Purge SkiaGL texture cache on memory pressure for b2gv1.2

A patch for b2g v1.2 made from attachment 821760 [details] [diff] [review].

Comment 11

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8334008 [details] [diff] [review]
Purge SkiaGL texture cache on memory pressure for b2gv1.2

snorp, can you review the patch? It is just apply attachment 821760 [details] [diff] [review] to b2g v1.2.

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8334008 [details] [diff] [review]
Purge SkiaGL texture cache on memory pressure for b2gv1.2

Review of attachment 8334008 [details] [diff] [review]:
-----------------------------------------------------------------

Were there any changes from the original patch? Looks fine to me.

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #12)
> Comment on attachment 8334008 [details] [diff] [review]
> Purge SkiaGL texture cache on memory pressure for b2gv1.2
> 
> Review of attachment 8334008 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Were there any changes from the original patch? Looks fine to me.

Thanks. There is no change from the original. Just fix a conflict around the following. Master does not have '#include "nsReadableUtils.h"' line.

---------------------------------------
 #include "nsILocaleService.h"
+#include "nsIObserverService.h"
 #include "nsReadableUtils.h"

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: Purge SkiaGL texture cache on memory pressure for b2gv1.2 ver2

Committable patch. Carry 'snorp review+'.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/55bad938f0ba

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/36becb933f78

https://tbpl.mozilla.org/php/getParsedLog.php?id=30722263&tree=Mozilla-B2g26-v1.2

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #16)
> Backed out for bustage.
> https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/36becb933f78
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=30722263&tree=Mozilla-B2g26-
> v1.2

Build failure for Mac OS. It seems need to add header file.

Comment 18

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #17)
> > https://tbpl.mozilla.org/php/getParsedLog.php?id=30722263&tree=Mozilla-B2g26-
> > v1.2
> 
> Build failure for Mac OS. It seems need to add header file.

Dependent on Comment 17, I did tryserver. But it failed because of error on debug build. 'NS_strcmp(aTopic, "memory-pressure")' part failed because of error. On b2g v1.2, it could not be compiled. 
   https://tbpl.mozilla.org/?tree=Try&rev=6a3a494ed965

Comment 19

[Sotaro Ikeda [:sotaro]]

Attachment: Purge SkiaGL texture cache on memory pressure for b2gv1.2 ver3

Fix build error on b2g v1.2 debug build. Carry "snorp review+".

Comment 20

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=6a3a494ed965

Comment 21

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #20)
> https://tbpl.mozilla.org/?tree=Try&rev=6a3a494ed965

Build becomes OK.

Comment 22

[Sotaro Ikeda [:sotaro]]

Need to check-in branch b2g v1.2 patch.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/9264d92c9862