Closed Bug 927260 Opened 7 years ago Closed 7 years ago

Gaia build uses a hardcoded "make" on windows builds

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

and this makes the build fail with mozmake.
https://tbpl.mozilla.org/php/getParsedLog.php?id=29171724&tree=Birch
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Blocks: 918414
Comment on attachment 817640 [details] [diff] [review]
Invoke the right gmake when building gaia

Review of attachment 817640 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/gaia/Makefile.in
@@ +17,5 @@
>    $(NULL)
> +endif
> +
> +ifdef .PYMAKE
> +GAIA_MAKE=$(GMAKE)

.PYMAKE implying GMAKE seems weird. If this is right, comment please.
Attachment #817640 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> .PYMAKE implying GMAKE seems weird. If this is right, comment please.

I merely transposed what that makefile already tries to do. I'll add a comment.
https://hg.mozilla.org/mozilla-central/rev/834b07614502
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.