927274 - B2G NFC: Add NFC Daemon for Nexus4

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/b2g-manifest

Need to support NFC for nexus4.
This patch only include adding the source to nexu4 source tree.
Enable nfc will in other patch

Comment 2

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/device-mako

start Nfc daemon service in init.mako.rc

Comment 3

[Michael Wu [:mwu]]

Can you add the service to gonk-misc/init.b2g.rc instead?

How do we determine if NFC is available?

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Michael Wu [:mwu] from comment #3)
> Can you add the service to gonk-misc/init.b2g.rc instead?
> 
> How do we determine if NFC is available?

I discussed this with device team Marco Chen before.
Since if NFC is available is hardware-dependent and currently mozilla NFC daemon is only available on Nexus4 (based on the Nexus4 broadcom chipset)
He suggest me put it directly on init.make.rc, otherwise we will need check Nexus4 only property in rc file
to determine if to start nfc servcice.

If we support more devices in the future, it will require add more property check in init.b2g.rc

Comment 5

[Marco Chen [:mchen]]

Yes, since device-mako is controlled by our own I suggested to put device-specific thing into device-mako not gonk-misc.
This is my 2 cents here.

By the way,

Dimi, do you make sure you need to add "oneshot" into your service category?
This mean that once ndfd is crashed  the init process will not restart it automatically.

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Marco Chen [:mchen] (Summit 10/03 ~10/08) from comment #5)
> Yes, since device-mako is controlled by our own I suggested to put
> device-specific thing into device-mako not gonk-misc.
> This is my 2 cents here.
> 
> By the way,
> 
> Dimi, do you make sure you need to add "oneshot" into your service category?
> This mean that once ndfd is crashed  the init process will not restart it
> automatically.

  Since enable/disable NFC function from gaia to deamon is not yet ready. Currently once nfc daemon is started,
  it will default enable some functions of nfc chip. So I just afraid if nfcd has a bug cause it crash every time
  after starting, it may cause any unknown side effect to the system since every time it starts it will do lots of
  things to the hardware.

  My original thought is removed oneshot after enable/disable function is ready.
  Do you suggest that i make it correct once ?

Comment 7

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to dlee from comment #6)
> (In reply to Marco Chen [:mchen] (Summit 10/03 ~10/08) from comment #5)
> > Yes, since device-mako is controlled by our own I suggested to put
> > device-specific thing into device-mako not gonk-misc.
> > This is my 2 cents here.
> > 
> > By the way,
> > 
> > Dimi, do you make sure you need to add "oneshot" into your service category?
> > This mean that once ndfd is crashed  the init process will not restart it
> > automatically.
> 
>   Since enable/disable NFC function from gaia to deamon is not yet ready.
> Currently once nfc daemon is started,
>   it will default enable some functions of nfc chip. So I just afraid if
> nfcd has a bug cause it crash every time
>   after starting, it may cause any unknown side effect to the system since
> every time it starts it will do lots of
>   things to the hardware.
> 
>   My original thought is removed oneshot after enable/disable function is
> ready.
>   Do you suggest that i make it correct once ?

As the discuss result with Marco.
Will use one-shot until NFCD is stable and Gaia support enable/disable NFC

Comment 8

[Kai-Chih Hu [:khu]]

Looks like we also target to land it in this sprint?

Comment 9

[Michael Wu [:mwu]]

Comment on attachment 817669 [details]
pull request to mozilla-b2g/b2g-manifest

Please fold the commits together into one. We'll also need to request git mirroring onto git.mozilla.org for this new repo. See bug 846821 for one example.

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 817693 [details]
pull request to mozilla-b2g/device-mako

Please put this in gonk-misc. nfcd won't/shouldn't exist on devices without nfc, so we can just add everything b2g platform specific to init.b2g.rc.

Comment 11

[Michael Wu [:mwu]]

While we're at it, I examined Android.mk in https://github.com/mozilla-b2g/platform_system_nfcd . LOCAL_MODULE_TAGS should be optional, not debug. nfcd should then be added to the PRODUCT_PACKAGES list in the device.mk, like: https://github.com/mozilla-b2g/device-mako/blob/b2g-4.3_r2.1/device.mk#L269 . Then nfcd will only be installed when necessary.

Comment 12

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g / gonk-misc

Comment 13

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 817693 [details]
pull request to mozilla-b2g/device-mako

Remove nfcd from init.mako.rc, add nfcd in PRODUCT_PACKAGES

Comment 14

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Michael,
  Could you help merge the pull requests ? Thanks

Comment 15

[Michael Wu [:mwu]]

As mentioned before, this will burn the tree unless you get the nfcd repo mirrored to git.mozilla.org.

Comment 16

[Dimi Lee [ooo 16.04 - 21.04］]

create Bug 931702 for mirror to git.mozilla.org

Comment 17

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/gonk-misc/commit/f6dbe3fbef904475ec8b98d744d215958bcfa80d
https://github.com/mozilla-b2g/device-mako/commit/454a34f0ed0b2cb29e2bb3f41e2c7fcf4fb84bb5
https://github.com/mozilla-b2g/b2g-manifest/commit/7504fc56622ed42d81b9604508fbaf9ab56570c1