927298 - Support wifi hotspot status APIs

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Wifi, defect)

Description

[Vincent Chang[:vchang][changyihsin]]

Currently, we use settings to indicate the enabling or disabling status of wifi hotspot. We need at least below APIs to indicate the status of wifi hotspot to gaia.  

   interface nsIDOMWifiManager : nsISupports
   {
     attribute nsIDOMEventListener onwifitetheringenabled;
     attribute nsIDOMEventListener onwifitetheringdisabled;
   }

Comment 1

[Ray REN]

Hi Vincent,

Any updates?

Comment 2

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: bug-927298-fix.patch

Comment 3

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: bug-927298-fix.patch

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: WIP patch v1

Comment 5

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Part1. wifi hotspot status webidl

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Part2. DOM and WifiWorker implementation

Comment 7

[Henry Chang [:hchang]]

Perfect! We finally can have an API to verify the tethering enable/disable result
in the test cases!

Comment 8

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8479687 [details] [diff] [review]
Part2. DOM and WifiWorker implementation

Review of attachment 8479687 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tethering/TetheringManager.js
@@ +41,3 @@
>      this.initDOMRequestHelper(aWindow, messages);
> +
> +    cpmm.sendSyncMessage("WifiManager:getState");

Do we need this for Tethering?

::: dom/wifi/WifiWorker.js
@@ +3444,5 @@
>      this.setWifiApEnabled(enabled, function() {
>        if ((enabled && WifiManager.tetheringState == "COMPLETED") ||
>            (!enabled && WifiManager.tetheringState == "UNINITIALIZED")) {
>          self._sendMessage(message, true, msg.data, msg);
> +        self._fireEvent("wifitetheringstateupdate", { state: enabled });

Do we still need the APIs? It seems that setTetheringEnabled() API has enough information to react tethering status.

Comment 9

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Vincent Chang[:vchang] from comment #8)
> Comment on attachment 8479687 [details] [diff] [review]
> Part2. DOM and WifiWorker implementation
> 
> Review of attachment 8479687 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/tethering/TetheringManager.js
> @@ +41,3 @@
> >      this.initDOMRequestHelper(aWindow, messages);
> > +
> > +    cpmm.sendSyncMessage("WifiManager:getState");
> 
> Do we need this for Tethering?
> 
In WifiWorker's implementation, getState will register domManager so if there is any event fired from WifiWorker, DOM layer can receive the message. For this patch, the required message is wifitetheringstateupdate.

> ::: dom/wifi/WifiWorker.js
> @@ +3444,5 @@
> >      this.setWifiApEnabled(enabled, function() {
> >        if ((enabled && WifiManager.tetheringState == "COMPLETED") ||
> >            (!enabled && WifiManager.tetheringState == "UNINITIALIZED")) {
> >          self._sendMessage(message, true, msg.data, msg);
> > +        self._fireEvent("wifitetheringstateupdate", { state: enabled });
> 
> Do we still need the APIs? It seems that setTetheringEnabled() API has
> enough information to react tethering status.

If a webpage only interested in knowing tethering state change , he can listen to this event to know if any other webpage change the tethering status by using setTetheringEnabled API.

Comment 10

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Vincent,
Could you help check if comment 9 is reasonable. thanks

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #9)
> (In reply to Vincent Chang[:vchang] from comment #8)
> > Comment on attachment 8479687 [details] [diff] [review]
> > Part2. DOM and WifiWorker implementation
> > 
> > Review of attachment 8479687 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: dom/tethering/TetheringManager.js
> > @@ +41,3 @@
> > >      this.initDOMRequestHelper(aWindow, messages);
> > > +
> > > +    cpmm.sendSyncMessage("WifiManager:getState");
> > 
> > Do we need this for Tethering?
> > 
> In WifiWorker's implementation, getState will register domManager so if
> there is any event fired from WifiWorker, DOM layer can receive the message.
> For this patch, the required message is wifitetheringstateupdate.

Yeah, you are right. So we should prevent _fireEvent() sending message to wrong dommanager?   
 
> > ::: dom/wifi/WifiWorker.js
> > @@ +3444,5 @@
> > >      this.setWifiApEnabled(enabled, function() {
> > >        if ((enabled && WifiManager.tetheringState == "COMPLETED") ||
> > >            (!enabled && WifiManager.tetheringState == "UNINITIALIZED")) {
> > >          self._sendMessage(message, true, msg.data, msg);
> > > +        self._fireEvent("wifitetheringstateupdate", { state: enabled });
> > 
> > Do we still need the APIs? It seems that setTetheringEnabled() API has
> > enough information to react tethering status.
> 
> If a webpage only interested in knowing tethering state change , he can
> listen to this event to know if any other webpage change the tethering
> status by using setTetheringEnabled API.

Make sense.

Comment 12

[Dimi Lee [ooo 16.04 - 21.04］]

Not actively working on this, if anyone is interested in this please feel free to take it.

Comment 13

[BMO Automation]

Firefox OS is not being worked on