[Flatfish][Homescreen] hide add collection menu option when searchbar is hidden

RESOLVED FIXED

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

(Blocks: 1 bug)

unspecified
Other
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3+)

Details

(Whiteboard: [Flatfish only][developer+])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
followup bug 920445

hide `add collection` menu option when searchbar is hidden
(Assignee)

Updated

4 years ago
Assignee: nobody → gasolin
Blocks: 903304
blocking-b2g: --- → koi?
(Assignee)

Comment 1

4 years ago
When long press homescreen, there will be 2 items ['change wallpaper','add collection']

expect:

only show ['change wallpaper'] when searchbar is disabled
(Assignee)

Comment 2

4 years ago
Created attachment 818265 [details]
pull request redirect to github
Attachment #818265 - Flags: review?(crdlc)
(Assignee)

Updated

4 years ago
Depends on: 920445
Comment on attachment 818265 [details]
pull request redirect to github

This is not the correct path sorry. The code is ready to show different UIs with or without ev.me

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/homescreen.js#L89

Please review this line, thanks a lot
Attachment #818265 - Flags: review?(crdlc) → review-

Comment 4

4 years ago
this is a must for flatfish since e.me should be removed from flatfish. according to triage result, its koi+
blocking-b2g: koi? → koi+
Whiteboard: [Flatfish only]
(Assignee)

Comment 5

4 years ago
Created attachment 818389 [details]
2nd pull request

Thanks for point out that, send another patch to fix it
Attachment #818389 - Flags: review?(crdlc)
Comment on attachment 818389 [details]
2nd pull request

Perfect! Great work. Please review a minor comment in github, thanks a lot
Attachment #818389 - Flags: review?(crdlc) → review+
Status: NEW → ASSIGNED
(Assignee)

Comment 7

4 years ago
fixed and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5c85c92618b0e78110dff9a83c88bf2ad52535b5

thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 5c85c92618b0e78110dff9a83c88bf2ad52535b5
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(gasolin)
(Assignee)

Comment 9

4 years ago
Hi john, this uplift is blocked by bug 920445, which depends on a huge e.me patch...
Flags: needinfo?(gasolin)
Collections aren't targeted to be part of the 1.2 release - so moving to 1.3?
blocking-b2g: koi+ → 1.3?

Updated

4 years ago
blocking-b2g: 1.3? → 1.3+
Whiteboard: [Flatfish only] → [Flatfish only][developer+]
You need to log in before you can comment on or make changes to this bug.