927959 - Cannot preinstall a hosted app with appcache in a SIM customization variant

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Jason Smith [:jsmith]]

Attachment: webapps.json

Build: 10/17/2013 Master Leo

STR

1. Follow https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup to setup your build with a AT&T Mobile US SIM included
2. Complete the FTE
3. Analyze & launch the Accuweather app

Expected

Accuweather should be preinstalled with the correct icon & launch to m.accuweather.com.

Actual

Accuweather has a downloading icon spinning infinitely & fails to launch upon clicking the icon.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: custom-appcache.patch

We had 2 issues: not trying to trigger queued downloads for non-packaged apps, and after that since these install happen so soon the network is usually down which means that we didn't install properly either.

Comment 2

[Gregor Wagner [:gwagner]]

Thanks Fabrice!

Comment 3

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8f80ef327cd0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f80ef327cd0

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/65cca6c736ee

Comment 6

[Jason Smith [:jsmith]]

Tried multiple attempts, but wikipedia & accuweather still fail to preinstall for me. Filed bug 934017 as a followup.

Comment 7

[rafael.marquez]

I have done several tests and I have a question. 
If we complete the FTE without internet connection, hosted apps are installed with the default icon. Is this correctly  or should be installed with  the specific app icon?

Comment 8

[Jason Smith [:jsmith]]

(In reply to rafael.marquez from comment #7)
> I have done several tests and I have a question. 
> If we complete the FTE without internet connection, hosted apps are
> installed with the default icon. Is this correctly  or should be installed
> with  the specific app icon?

It should be the specific app icon - the internet connection shouldn't have an effect during the preinstalling process. If it does, it's a bug & it's a blocker - our content requirements require that apps must be preinstalled with the right grid of icons when the user first sees the phone.

Comment 9

[rafael.marquez]

Now, If you complete the FTE without internet connection hosted apps are installed with the default icon. do you have a bug opened for this feature? 

(In reply to Jason Smith [:jsmith] from comment #8)
> (In reply to rafael.marquez from comment #7)
> > I have done several tests and I have a question. 
> > If we complete the FTE without internet connection, hosted apps are
> > installed with the default icon. Is this correctly  or should be installed
> > with  the specific app icon?
> 
> It should be the specific app icon - the internet connection shouldn't have
> an effect during the preinstalling process. If it does, it's a bug & it's a
> blocker - our content requirements require that apps must be preinstalled
> with the right grid of icons when the user first sees the phone.

Comment 10

[Marcelino Veiga Tuimil [:sonmarce]]

It seems it depends on the kind of hosted app, we will add the details to clarify what is the expected result each case

Comment 11

[[:fabrice] Fabrice Desré]

no network = no way to get the icon... Does it appear when the device goes online? The other (bad) option is to use a data: uri for the icon url.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Fabrice Desré [:fabrice] from comment #11)
> no network = no way to get the icon... Does it appear when the device goes
> online? The other (bad) option is to use a data: uri for the icon url.

Actually, I think the old 1.01 & 1.1 customizations were using data URIs actually to ensure that you had an icon when you first launch the homescreen, even if no network was present.

Example - https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/external-apps/facebook/manifest.webapp

Comment 13

[Jason Smith [:jsmith]]

(In reply to rafael.marquez from comment #9)
> Now, If you complete the FTE without internet connection hosted apps are
> installed with the default icon. do you have a bug opened for this feature? 

Nope, I haven't filed a bug about this yet.