928068 - Story - Don't allow switching to Metro while in private browser mode

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Brian R. Bondy [:bbondy]]

Until we have support for private browsing in Metro, we should not give the user the option to switch to Metro if they are in private browsing mode on Desktop.

Comment 1

[Brian R. Bondy [:bbondy]]

p=2

Comment 2

[(no longer active)]

(In reply to Brian R. Bondy [:bbondy] from comment #0)
> Until we have support for private browsing in Metro, we should not give the
> user the option to switch to Metro if they are in private browsing mode on
> Desktop.

That doesn't make sense to me.  There is no "private browsing mode" any more, all you have is private windows.

I think this is WONTFIX.

Comment 3

[Brian R. Bondy [:bbondy]]

I don't think this is WONTFIX.
I don't think we want to present the user with the option to relaunch in Metro if they are in a private browser window.  Because they may think that they are relaunching in Metro mode while maintaining their private status. This was originally a concern brought up by Asa by the way.

Comment 4

[Marina Samuel [:emtwo]]

Attachment: v1: Disallow switch to metro in australis when private browsing

If we use the patch from bug 934032 comment 16, this patch should do the trick for disallowing switching to metro when private browsing

Comment 5

[Marina Samuel [:emtwo]]

By the way, the patch from comment 4 makes the 'metro mode' button not visible for windows in private mode so these windows cannot be switched over to metro, but normal windows can.

Comment 6

[(no longer active)]

Marina demoed what this bug is about to me in person.  I was confused when reading comment 0, but what she has implemented in this bug makes sense to me now!

Comment 7

[Brian R. Bondy [:bbondy]]

Great, thanks for keeping an eye out! :D

Comment 8

[Marina Samuel [:emtwo]]

Attachment: v1: Disallow switch to metro when private browsing

This one is for oak/mc

Comment 9

[Brian R. Bondy [:bbondy]]

Comment on attachment 831708 [details] [diff] [review]
v1: Disallow switch to metro when private browsing

Review of attachment 831708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-appmenu.inc
@@ +5,5 @@
>  
>  <menupopup id="appmenu-popup"
>             onpopupshowing="if (event.target == this) {
>                               updateEditUIVisibility();
> +                             CheckForPrivateMode();

nit: Please call this updateMetroVisibility()

Comment 10

[Brian R. Bondy [:bbondy]]

updateSwitchToMetroVisibility

Comment 11

[Marina Samuel [:emtwo]]

Attachment: v2: Disallow switch to metro when private browsing for Holly

Addressed comment

Comment 12

[Brian R. Bondy [:bbondy]]

Comment on attachment 8333885 [details] [diff] [review]
v2: Disallow switch to metro when private browsing for Holly

Review of attachment 8333885 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to carry forward r+s btw. Thanks :D

Comment 13

[Brian R. Bondy [:bbondy]]

Landed on oak here:
https://hg.mozilla.org/projects/oak/rev/e15485cd77ad

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.

Comment 14

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/074a7f87397c

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/074a7f87397c

Comment 16

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/holly/rev/7f73c5b97f2c

Comment 17

[Manuela Muntean [Away]]

Verified as fixed for iteration #19, with latest Nightly from 2013-12-01 on Win 8 64-bit.

While in a private window, the "Metro Mode" button doesn't appear in the Customize panel, therefore Metro can't be launched in this situation.