Closed Bug 928068 Opened 7 years ago Closed 7 years ago

Story - Don't allow switching to Metro while in private browser mode

Categories

(Firefox :: General, defect, P2)

x86_64
Windows NT
defect

Tracking

()

VERIFIED FIXED
Firefox 28

People

(Reporter: bbondy, Assigned: emtwo)

References

Details

(Whiteboard: [completed-oak][block28] feature=story c=tbd u=tbd p=2)

Attachments

(2 files, 1 obsolete file)

Until we have support for private browsing in Metro, we should not give the user the option to switch to Metro if they are in private browsing mode on Desktop.
p=2
Summary: Don't allow switching to Metro while in private browser mode → Story - Don't allow switching to Metro while in private browser mode
Whiteboard: feature=story c=tbd u=tbd p=2
Whiteboard: feature=story c=tbd u=tbd p=2 → [block28] feature=story c=tbd u=tbd p=2
Whiteboard: [block28] feature=story c=tbd u=tbd p=2 → [release28] feature=story c=tbd u=tbd p=2
Assignee: netzen → msamuel
Blocks: metrov1it19
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [release28] feature=story c=tbd u=tbd p=2 → [block28] feature=story c=tbd u=tbd p=2
(In reply to Brian R. Bondy [:bbondy] from comment #0)
> Until we have support for private browsing in Metro, we should not give the
> user the option to switch to Metro if they are in private browsing mode on
> Desktop.

That doesn't make sense to me.  There is no "private browsing mode" any more, all you have is private windows.

I think this is WONTFIX.
I don't think this is WONTFIX.
I don't think we want to present the user with the option to relaunch in Metro if they are in a private browser window.  Because they may think that they are relaunching in Metro mode while maintaining their private status. This was originally a concern brought up by Asa by the way.
If we use the patch from bug 934032 comment 16, this patch should do the trick for disallowing switching to metro when private browsing
Attachment #831603 - Attachment is patch: true
By the way, the patch from comment 4 makes the 'metro mode' button not visible for windows in private mode so these windows cannot be switched over to metro, but normal windows can.
Marina demoed what this bug is about to me in person.  I was confused when reading comment 0, but what she has implemented in this bug makes sense to me now!
Great, thanks for keeping an eye out! :D
This one is for oak/mc
Attachment #831603 - Flags: review?(netzen)
Attachment #831708 - Flags: review?(netzen)
Comment on attachment 831708 [details] [diff] [review]
v1: Disallow switch to metro when private browsing

Review of attachment 831708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-appmenu.inc
@@ +5,5 @@
>  
>  <menupopup id="appmenu-popup"
>             onpopupshowing="if (event.target == this) {
>                               updateEditUIVisibility();
> +                             CheckForPrivateMode();

nit: Please call this updateMetroVisibility()
Attachment #831708 - Flags: review?(netzen) → review+
updateSwitchToMetroVisibility
Attachment #831603 - Flags: review?(netzen) → review+
Addressed comment
Attachment #831708 - Attachment is obsolete: true
Comment on attachment 8333885 [details] [diff] [review]
v2: Disallow switch to metro when private browsing for Holly

Review of attachment 8333885 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to carry forward r+s btw. Thanks :D
Attachment #8333885 - Flags: review+
Attachment #8333885 - Attachment description: v2: Disallow switch to metro when private browsing → v2: Disallow switch to metro when private browsing for Holly
Landed on oak here:
https://hg.mozilla.org/projects/oak/rev/e15485cd77ad

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 935099
Whiteboard: [block28] feature=story c=tbd u=tbd p=2 → [completed-oak][block28] feature=story c=tbd u=tbd p=2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
https://hg.mozilla.org/integration/fx-team/rev/074a7f87397c
Target Milestone: --- → Firefox 28
Blocks: 944563
https://hg.mozilla.org/mozilla-central/rev/074a7f87397c
Status: NEW → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Verified as fixed for iteration #19, with latest Nightly from 2013-12-01 on Win 8 64-bit.

While in a private window, the "Metro Mode" button doesn't appear in the Customize panel, therefore Metro can't be launched in this situation.
Status: RESOLVED → VERIFIED
Depends on: 947988
Depends on: 961285
Product: Firefox for Metro → Firefox
You need to log in before you can comment on or make changes to this bug.