928292 - [DSDS][Gaia] System should handle multiple sim card locks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

- When users unlock the device, dialogs that allow users to unlock multiple sim cards should be displayed.
- When users launch apps that need a locked sim card, an unlocking dialog should also be displayed.

Comment 1

[Anshul]

Hey Sandip, if both the SIMs in DSDS are PIN locked wouldn't we need support for this bug to unlock both SIMs? If yes, then this should be 1.3+

Comment 2

[Kai-Chih Hu [:khu]]

Arthur, do we know when we could finish this bug? Thanks!

Comment 3

[Sandip Kamat]

(In reply to Anshul from comment #1)
> Hey Sandip, if both the SIMs in DSDS are PIN locked wouldn't we need support
> for this bug to unlock both SIMs? If yes, then this should be 1.3+

Correct. It is for 1.3.

Comment 4

[Kai-Chih Hu [:khu]]

Plan to land it in the 2nd week of sprint 6.

Comment 5

[Kai-Chih Hu [:khu]]

The comment #4 is still valid.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Steal

Comment 7

[Kai-Chih Hu [:khu]]

What's the status now?

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Have a working patch, writing tests now.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: DSDS SIM PIN

Rock DSDS!

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8343041 [details] [review]
DSDS SIM PIN

Thank you for taking the initiative and helping out!

Comment 12

[Kai-Chih Hu [:khu]]

We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Travis is green now, merging.
https://travis-ci.org/mozilla-b2g/gaia/builds/15206219

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/dfd6a873b5cd57943f5988c202b03e17262c52cd

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Request the approval of uplifting this patch to the v1.3 branch. 

This blocks one of the major DSDS features and also partner's tests. We have
unit tests for the modified part (sim_pin_dialog) and also the tests for the newly
added module. This feature is also covered by moztraps as it is part of the
v1.3 user story.

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Alive, I believe Bug 946603 will also block this bug, am I correct?

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Yes for: the retryCount=-1 always is a regression.

Comment 18

[[:fabrice] Fabrice Desré]

(In reply to Alive Kuo [:alive][NEEDINFO] from comment #15)
> Request the approval of uplifting this patch to the v1.3 branch. 
> 
> This blocks one of the major DSDS features and also partner's tests. We have
> unit tests for the modified part (sim_pin_dialog) and also the tests for the
> newly
> added module. This feature is also covered by moztraps as it is part of the
> v1.3 user story.

Ok, feel free to merge.

Comment 19

[Anshul]

What's the ETA on uplifting this to 1.3?

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Need followup 928852 to be 1.3+ as well in order not to break 1.3

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

c0aa854489c102fad8ea7deac68f4e36fbe39e2a
v1.3

Comment 22

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Alive Kuo [:alive][NEEDINFO] from comment #20)
> Need followup 928852 to be 1.3+ as well in order not to break 1.3

I saw bug 928852 is duplicate to bug 928847, which is RESOLVED INVALID.
What's the plan we can take to get it landed in 1.3?

Comment 23

[(inactive after 6/18) Alive Kuo [:alive]]

I put the wrong bug number :(
It's bug 948852 and already 1.3+

THX!