Closed Bug 921390 Opened 6 years ago Closed 6 years ago

[DSDS][Gaia] Need to show carries' names in lock screen for DSDS.

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:1.3+, firefox29 fixed, b2g-v1.3 fixed)

RESOLVED FIXED
1.3 Sprint 6 - 12/6
blocking-b2g 1.3+
Tracking Status
firefox29 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: kchang, Assigned: arthurcc)

References

Details

(Whiteboard: [FT:RIL] [L2])

Attachments

(1 file)

User should be able to see operator names per SIM in homescreen as well as lock screen
Blocks: 918553
This bug blocks another user story bug.
Blocks: 921980
No longer blocks: 918553
Do we know the possible target milestone for this bug? Thank you.
blocking-b2g: --- → 1.3+
Flags: needinfo?(arthur.chen)
Set the milestone to 1.3 sprint 4.
Flags: needinfo?(arthur.chen)
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Whiteboard: [FT:RIL]
Target Milestone: 1.3 Sprint 4 - 11/8 → 1.3 Sprint 5 - 11/22
Blocks: 930299
Whiteboard: [FT:RIL] → [FT:RIL] [L2]
Target Milestone: 1.3 Sprint 5 - 11/22 → 1.3 Sprint 6 - 12/6
Plan to land in the 1st week of sprint 6.
Alive, could you help review the patch? I've listed some special cases in github. If you need a fugu device to have some tests, please let me know, thanks!
Attachment #8341602 - Flags: review?(alive)
Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Let's have lockscreen_mobile module.
Attachment #8341602 - Flags: review?(alive) → review+
Is there anything else we need to work on this bug?
Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Alive, I've separated a module handing mobile connection related information. Please have a look.

Anshul, please have a try on this patch. 

Thanks!
Attachment #8341602 - Flags: feedback?(anshulj)
Attachment #8341602 - Flags: feedback?(alive)
Attachment #8341602 - Flags: feedback?(alive) → feedback+
Can be landed today.
Blocks: 942267
No longer blocks: 930299
Arthur, I am really sorry I couldn't test this bug as promised yesterday. I will do my best to test it tomorrow but please don't wait for my feedback before merging this change.
Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Alive, could you help review the patch? Thanks!
Attachment #8341602 - Flags: review?(alive)
Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

++++ pay attention to conflict
Attachment #8341602 - Flags: review?(alive)
Attachment #8341602 - Flags: review+
Attachment #8341602 - Flags: feedback?(anshulj)
Arhtur, I am not able to apply your patch as there are conflicts.
I've rebased it to master. Could you try it again? Thanks.
In case Anshul didn't see the update.
Flags: needinfo?(anshulj)
Arthur, I am still seeing issue with patch not applying. I suggest you merge the change and I will file and follow up bugs if I see any issue.
Flags: needinfo?(anshulj)
Depends on: 928292
No longer depends on: 946125
The patch depends on bug 928292 so that I'm not able to merge it now. Could you try to use the branch in my pull request?
We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.
Kevin, I can land this as bug 928292 has been merged. Thanks.
Request the approval of uplifting this patch to the v1.3 branch. 

This blocks one of the major DSDS features and also partner's tests. We have unit tests for the modified part (lockscreen) and also the tests for the newly added module. This feature is also covered by moztraps as it is part of the v1.3 user story.
Flags: needinfo?(fabrice)
Arthur, Ok to merge on 1.3
Flags: needinfo?(fabrice)
master: 552c6661aa4549ae62d660d220e893db39a8a320
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
v1.3: e01c4d516003fd0773781382315563ae38fe08c2
Depends on: 950070
You need to log in before you can comment on or make changes to this bug.