921390 - [DSDS][Gaia] Need to show carries' names in lock screen for DSDS.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Ken Chang[:kenkai]]

User should be able to see operator names per SIM in homescreen as well as lock screen

Comment 1

[Ken Chang[:kenkai]]

This bug blocks another user story bug.

Comment 2

[Kai-Chih Hu [:khu]]

Do we know the possible target milestone for this bug? Thank you.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Set the milestone to 1.3 sprint 4.

Comment 4

[Kai-Chih Hu [:khu]]

Plan to land in the 1st week of sprint 6.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/14301

Alive, could you help review the patch? I've listed some special cases in github. If you need a fugu device to have some tests, please let me know, thanks!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Let's have lockscreen_mobile module.

Comment 7

[Kai-Chih Hu [:khu]]

Is there anything else we need to work on this bug?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Alive, I've separated a module handing mobile connection related information. Please have a look.

Anshul, please have a try on this patch. 

Thanks!

Comment 9

[Kai-Chih Hu [:khu]]

Can be landed today.

Comment 10

[Anshul]

Arthur, I am really sorry I couldn't test this bug as promised yesterday. I will do my best to test it tomorrow but please don't wait for my feedback before merging this change.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

Alive, could you help review the patch? Thanks!

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8341602 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14301

++++ pay attention to conflict

Comment 13

[Anshul]

Arhtur, I am not able to apply your patch as there are conflicts.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

I've rebased it to master. Could you try it again? Thanks.

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

In case Anshul didn't see the update.

Comment 16

[Anshul]

Arthur, I am still seeing issue with patch not applying. I suggest you merge the change and I will file and follow up bugs if I see any issue.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

The patch depends on bug 928292 so that I'm not able to merge it now. Could you try to use the branch in my pull request?

Comment 18

[Kai-Chih Hu [:khu]]

We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Kevin, I can land this as bug 928292 has been merged. Thanks.

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Request the approval of uplifting this patch to the v1.3 branch. 

This blocks one of the major DSDS features and also partner's tests. We have unit tests for the modified part (lockscreen) and also the tests for the newly added module. This feature is also covered by moztraps as it is part of the v1.3 user story.

Comment 21

[[:fabrice] Fabrice Desré]

Arthur, Ok to merge on 1.3

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 552c6661aa4549ae62d660d220e893db39a8a320

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.3: e01c4d516003fd0773781382315563ae38fe08c2