928419 - Ruleset ignored due to bad selector (at browser/themes/windows/downloads/indicator-aero.css#26)

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This error shows up in the Browser Console.

>  /* This is the case where the downloads indicator has been moved next to the menubar as well as
>     the case where the downloads indicator is in the tabstrip toolbar. */
>  :-moz-any(#toolbar-menubar #downloads-button:not([counter]), #TabsToolbar #downloads-button:not(:-moz-lwtheme):not([counter])) > #downloads-indicator-anchor > #downloads-indicator-progress-area > #downloads-indicator-counter {
>    background-image: -moz-image-rect(url("chrome://browser/skin/Toolbar-inverted.png"), 0, 108, 18, 90);
>  }

at http://hg.mozilla.org/projects/ux/annotate/3b44793578f6/browser/themes/windows/downloads/indicator-aero.css#l17

It looks like it was introduced by revision e6027b217801 (no bug). I can't find the related source code in m-c, so marking this as blocking Australis.

Comment 1

[:Gijs (he/him)]

Actually, it's from http://hg.mozilla.org/projects/ux/diff/c197150217d6/browser/themes/windows/downloads/downloads-aero.css (I just moved it as part of the merge, because downloads-aero.css had been split into downloads-aero.css and indicator-aero.css on m-c). That's bug 755593. :-)

I'll write up the trivial fix here tomorrow.

Comment 2

[:Gijs (he/him)]

Attachment: fix CSS error in indicator-aero.css,

This should do it.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

What was wrong with the CSS before? Maybe I'm missing something, but all I see in the patch is that :-moz-any() is being expanded out.

Comment 4

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] from comment #3)
> What was wrong with the CSS before? Maybe I'm missing something, but all I
> see in the patch is that :-moz-any() is being expanded out.

That is exactly what is necessary. :-moz-any can't contain "complex" selectors, like the descendant selectors that are currently there. [0]

[0] See the note at: https://developer.mozilla.org/en-US/docs/Web/CSS/:any#Values

Comment 5

[:Gijs (he/him)]

Attachment: fix CSS error in indicator-aero.css,

However, I just tested this, and the offset that's already there is wrong. Fixed now.

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/d921c9f16a5c

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/d921c9f16a5c