928566 - Use more descriptive parameter names in robocop assertion methods

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The Assert class [1] has assertions such as:

void is(Object a, Object b, String name);

However, in the test output, one of 'a' and 'b' is the expected value and the other is the actual value - they are not interchangeable. This is ambiguous and causes bugs such as bug 928564.

Similarly, Assert's implementations, FennecTalosAssert and FennecMochitestAssert should be corrected.

[1]: https://mxr.mozilla.org/mozilla-central/source/build/mobile/robocop/Assert.java.in

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Use more descriptive parameter names in robocop assertion methods.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/a0b73fde685b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0b73fde685b