928612 - [Gallery] [Camera] Refactoring of exif metadata parser

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, enhancement)

Description

[Diego Marcos [:dmarcos]]

This bugs tracks the refactoring of the exif meta data parser used by the camera and the gallery apps.

Comment 1

[Diego Marcos [:dmarcos]]

I factored out the parser to a separate repository. This makes the code easier to test and improves encapsulation and modularity of the gaia code base.

Comment 2

[Diego Marcos [:dmarcos]]

Merge into master:

https://github.com/mozilla-b2g/exif-parser/commit/78f21d57cb812435184b6f8d5ce0ac5bd8d7c012

Comment 3

[Candice Serran (:cserran)]

(In reply to Diego Marcos from comment #2)
> Merge into master:
> 
> https://github.com/mozilla-b2g/exif-parser/commit/
> 78f21d57cb812435184b6f8d5ce0ac5bd8d7c012

Diego, did this land? If so, can you please update the ticket status?

Comment 4

[Diego Marcos [:dmarcos]]

Got some improvements requests from David Flanagan. Adding the bugs as dependencies. This is postponed to 1.4.

Comment 5

[Hubert Figuiere [:hub]]

Is there any chance this could be landed for 2.5? Do you need help finishing it?

I'm trying to set a goal of fixing the photo upload workflow this is a major pain point, part of the MVP.

Comment 6

[Diego Marcos [:dmarcos]]

This is obsolete. The EXIF parser should be usable in its current state. For bugs and improvements feel free to file issues on the github repo and I can jump and help:

https://github.com/mozilla-b2g/exif-parser

Comment 7

[Diego Marcos [:dmarcos]]

I'm going to keep it open. I just to need a bit more if any of the two dependency bugs still make sense. In any case the parser can be used as it is. Any improvement can be done in parallel. I wouldn't block any gaia work on this bug

Comment 8

[Hubert Figuiere [:hub]]

so we should get rid of shared/js/media/jpeg_metadata_parser.js ?

Comment 9

[Diego Marcos [:dmarcos]]

I think we should be able to get rid of it. djf had concerns about the performance of the new parser. If we make sure that we don't introduce regressions we should land it.

Comment 10

[Hubert Figuiere [:hub]]

We should land it. And figure out regressions. We need this. Really.

If you want I can tackle this since it is basically blocking a bunch of other things I want to see happening.

Comment 11

[Diego Marcos [:dmarcos]]

Yes, go ahead.

Comment 12

[Hubert Figuiere [:hub]]

I'm gonna use this as a tracker for the various tasks.

Comment 13

[BMO Automation]

Firefox OS is not being worked on