928876 - Inappropriate line break in tabzilla for some locales

Status: RESOLVED WONTFIX

(Websites :: Tabzilla, defect)

Description

[Jørgen Rasmussen]

Some localizations of the word 'Innovations' are too long, resulting in an inappropriate line break. The last character of the word ends up on a new line.
Affected locales:
da, de, es-MX, es-CL, es-AR. There might be more.

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: Tabzilla layout tweaks

I have thought the same thing. How about widening the columns like this?

Comment 2

[Jørgen Rasmussen]

I like this solution. Widening all columns would probably solve similar problems with translations in the other columns.

Comment 3

[Kohei Yoshino [:kohei]]

:pascalc feedback?

At least the line breaks should be avoided by using CSS text-overflow.

Comment 4

[Kohei Yoshino [:kohei]]

Sorry for the bugspam -- the Target Milestore was set unexpectedly.

Comment 5

[Pascal Chevrel:pascalc]

I like this new layout, it gives locales a lot more space for strings.

Comment 6

[Kohei Yoshino [:kohei]]

pascalc: thanks, I'll send a PR!

Comment 7

[Kohei Yoshino [:kohei]]

Attachment: Pull request on GitHub

Comment 8

[Kohei Yoshino [:kohei]]

I have tested some locales and the new layout works fine.

Added a link to the home page to fix Bug 742598 too.

Note that the "Home" is not included in main.lang but in lightbeam.lang. We have to move the string manually.

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: Updated screenshot

en-US, an and da. In the an locale, Developer Network and Website Directory are both broken into 2 lines, but still fit in the new layout.

Comment 10

[Steven Garrity [:sgarrity]]

Adding smartell for design feedback.

I've been wondering if we should drop the "HOME" link (which is not clear whether it's the Mozilla home page, or the home page of whatever page tabzilla is one). Instead, we could link the four column headings:

MOZILLA (mozilla.org)
PRODUCTS (mozilla.org/products)
INNOVATIONS (?)
GET INVOLVED (mozilla.org/contribute)

While we're at it, we should remove "PROJECTS" from the Mozilla column (it just redirects to /products, which already has a column/links). If we linked Get Involved to /contribute, we may also be able to eliminate the VOLUNTEER link.

These changes would reduce the max number of rows to 4.

Alternately, the WEBSITE DIRECTORY link could move under the MOZILLA column.

Sean?

Comment 11

[Kohei Yoshino [:kohei]]

The links in Tabzilla can be organized... in some way. WebFWD, Labs and Webmaker are actually on the Product page. Research is not there though. Support can be under Products? How about Add-ons and Marketplace? Developer (Network) can be under Get Involved? Hmm...

So I thought we could revisit those links later, and focus on the layout issue and the Home link this time.

Comment 12

[Kohei Yoshino [:kohei]]

So the pull request has been closed. How can we fix this issue?

Comment 14

[Tim [:pollti]]

Attachment: mozilla_org_german.png

There's one more issue in the german edition (de). The word "ENTWICKLERNETZWERK" is too long for the column "MOZILLA", but I think that would be fixed with the planned changed. https://www.mozilla.org/de/

Comment 16

[Sean Martell]

We had some good discussion around what Tabzilla Next would be at our last Engagement all-hands. Let me look into what timelines are like and if that's something we could ramp up to help with these issues.

Comment 20

[Djfe]

wow doesn't look like the issue still exists.
What's the current status?

What do you think about using a min-width and in every other case let the browser decide which width is possible for the current page's width. (so no width and no max-width)

Comment 21

[Djfe]

ups ^^
I wanted to say:
looks like the issue still exists.

(I have edited the sentence during writing but didn't pay any attention to what I said before)

Comment 22

[Kohei Yoshino [:kohei]]

Yes, this issue still exists unfortunately.

Since Tabzilla.next has been delayed, can we fix it with my proposal as a temporary solution? The screenshot is attached in my comment 9. Thoughts anyone?

Comment 24

[Kohei Yoshino [:kohei]]

As you might know, Bug 1151579 has replaced Tabzilla with a static Mozilla tab. The old assets are still available, but no site is probably using it. Closing all Tabzilla-related open bugs at this moment.