929636 - Change appropriate tests to fail-if for Travis/desktopb2g manifest

Status: RESOLVED DUPLICATE of bug 934230

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[Zac C (:zac)]

Just awaiting a new release to Pypi of marionette client

Comment 2

[Zac C (:zac)]

Attachment: github pr

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 821534 [details] [review]
github pr

Looks great, thanks Zac. I'll leave the r? for Bebe though.

Comment 4

[Zac C (:zac)]

Yep, can't wait to do it on device tests too!

Comment 5

[Zac C (:zac)]

Thx!
https://github.com/mozilla-b2g/gaia/commit/7a16280b3809457def85ada076f1f0259153917e

Comment 6

[Julien Wajsberg [:julienw]]

This bug has another commit in :
https://github.com/mozilla-b2g/gaia/commit/afbf45f26a73b7cd5e0a831bea48087331975286

With this commit (not the first one), one ui test is failing on Travis, see https://travis-ci.org/mozilla-b2g/gaia/jobs/13048230

Do you know why ?

I'm not very happy that you didn't take the time to file a PR and wait for a green travis before merging this other commit (that isn't even mentioned on this bug).

I'm backing out that other commit right now.

Comment 7

[Julien Wajsberg [:julienw]]

Travis for the revert is https://travis-ci.org/mozilla-b2g/gaia/builds/13077295

Comment 8

[Zac C (:zac)]

Julien, test_browser_bookmark is now failing because Rik backed out the Gecko change that was causing it to fail. It is *NOT* this patch causing it.

If there is a commit to back out it is this one:
https://github.com/mozilla-b2g/gaia/commit/d0a48341b9f258f9971d79f225ceba58e382eceb

Comment 9

[Julien Wajsberg [:julienw]]

Ok, same tests are failing with the revert, this was a false alert then won't push the revert.

Comment 10

[Julien Wajsberg [:julienw]]

oki thanks Zac, will do this.

Comment 11

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13324

Pointer to Github pull-request

Comment 12

[Bob Silverberg [:bsilverberg]]

Comment on attachment 826435 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13324

Uplift to v1.2