929709 - [traceback] Task mkt.developers.tasks.validator[2108bc10-575f-4d1d-96e7-d8ca994a53f7] raised exception: AttributeError("'NoneType' object has no attribute 'log_feature'",)

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Task mkt.developers.tasks.validator[2108bc10-575f-4d1d-96e7-d8ca994a53f7] raised exception: AttributeError("'NoneType' object has no attribute 'log_feature'",)

Stacktrace (most recent call last):

  File "celery/task/trace.py", line 228, in trace_task
    R = retval = fun(*args, **kwargs)
  File "celery/task/trace.py", line 415, in __protected_call__
    return self.run(*args, **kwargs)
  File "nuggets/celeryutils.py", line 35, in wrapped
    return fun(*args, **kw)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "mkt/developers/tasks.py", line 57, in validator
    validation_result = run_validator(upload.path, url=kw.get('url'))
  File "mkt/developers/tasks.py", line 116, in run_validator
    spidermonkey=settings.SPIDERMONKEY)
  File "appvalidator/validate.py", line 71, in validate_packaged_app
    submain.prepare_package(bundle, path, timeout)
  File "appvalidator/submain.py", line 63, in prepare_package
    test_package(err, package, path)
  File "appvalidator/submain.py", line 94, in test_package
    output = test_inner_package(err, package)
  File "appvalidator/submain.py", line 119, in test_inner_package
    test(err, package)
  File "appvalidator/testcases/content.py", line 74, in test_packed_packages
    processed = _process_file(err, package, name, file_data)
  File "appvalidator/testcases/content.py", line 115, in _process_file
    testendpoint_js.test_js_file(err, name, file_data)
  File "appvalidator/testcases/scripting.py", line 53, in test_js_file
    trav.run(tree)
  File "appvalidator/testcases/javascript/traverser.py", line 59, in run
    func()
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 68, in wrap
    func()
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 62, in wrap
    traverser.traverse_node(node["body"])
  File "appvalidator/testcases/javascript/traverser.py", line 103, in traverse_node
    action_result = action(self, node)
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 23, in BlockStatement
    traverser.traverse_node(child)
  File "appvalidator/testcases/javascript/traverser.py", line 121, in traverse_node
    self.traverse_node(b)
  File "appvalidator/testcases/javascript/traverser.py", line 103, in traverse_node
    action_result = action(self, node)
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 23, in BlockStatement
    traverser.traverse_node(child)
  File "appvalidator/testcases/javascript/traverser.py", line 103, in traverse_node
    action_result = action(self, node)
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 29, in ExpressionStatement
    return traverser.traverse_node(node["expression"])
  File "appvalidator/testcases/javascript/traverser.py", line 103, in traverse_node
    action_result = action(self, node)
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 368, in AssignmentExpression
    right = traverser.traverse_node(node["right"])
  File "appvalidator/testcases/javascript/traverser.py", line 121, in traverse_node
    self.traverse_node(b)
  File "appvalidator/testcases/javascript/traverser.py", line 103, in traverse_node
    action_result = action(self, node)
  File "appvalidator/testcases/javascript/nodedefinitions.py", line 307, in BinaryExpression
    left = left.get_literal_value()
  File "appvalidator/testcases/javascript/jstypes.py", line 192, in get_literal_value
    directory = self._get_contents(traverser)
  File "appvalidator/testcases/javascript/jstypes.py", line 131, in _get_contents
    traverser, self.global_data["value"])
  File "appvalidator/testcases/javascript/utils.py", line 67, in evaluate_lambdas
    return evaluate_lambdas(traverser, node(traverser))
  File "appvalidator/testcases/javascript/predefinedentities.py", line 31, in wrap
    t.log_feature(constant)

Comment 1

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/597f086a1d0db2d85a60b41c2d8b9ef22b5a4e5b
https://github.com/mozilla/app-validator/commit/80fc530e9b99a61a55fbbd2933498c4edd3bf096

Comment 4

[Victor Carciu]

Can you please add some STRs to this bug or mark it as [qa-] ?

Comment 5

[krupa raj[:krupa]]

This was pushed live last Friday.