929824 - Debugger logging not pretty printed when remote end not logging

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

After the change in bug 923600, if you use a client with debugger logging enabled to connect a server with logging disabled, you no longer see pretty printed messages on the client.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Pretty print RDP on receive

This changes the previous patch from bug 923600 so we never pretty print over the wire, but if and only if the receiver is logging, then pretty print for them.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=389596abd8aa

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

This calls JSON.stringify (and wantLogging) twice though, right?

I guess it's a good tradeoff to make the local case with debug enabled slower, if this ends up making the remote case with debug disabled faster.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 820744 [details] [diff] [review]
Pretty print RDP on receive

Review of attachment 820744 [details] [diff] [review]:
-----------------------------------------------------------------

ok.

Nick just changed this in bug 923600.

I'm not a huge fan of stringifying more than once here, but don't have a good suggestion on how to ensure received packets that weren't pretty-printed get reformatted correctly.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The non-logging case is still as fast as possible: sender does a single stringify w/o indenting, and the receiver parses.

If you're logging, the receiver additionally stringifies with indenting.  So, I think it's a reasonable tradeoff, especially since the side that will actually be printing controls whether the indenting happens.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/fx-team/rev/7688cf08e31d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7688cf08e31d