929840 - [Settings] Select elements should use pure CSS where possible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Kevin Grandon :kgrandon]

I've noticed that after loading a settings panel, the buttons are intially unstyled, then the styles seem to apply after the panel loads.

In addition there is quite a bit of javascript that iterates through each select after a panel loads. I think that we should move this into pure CSS if possible. I've spoken to Pavel about this in the past, but I can't remember why we didn't migrate to a CSS approach.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Will create another bug for the flickering issue.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 820774 [details] [review]
Github pull request

Hi Pavel - Could you give this an initial review? I would like to land this as this removes a lot of duplicated code to simply keep the fake label in sync. I don't see why we need this as we should be able to do this in pure CSS. Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 820774 [details] [review]
Github pull request

Great job Kevin :) looks very good :)

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 820774 [details] [review]
Github pull request

Hi Evelyn - Looking for a settings peer to review this before landing. If you have the time would you be able to take a look at this?

Thanks!

Comment 6

[Evelyn Hung]

Comment on attachment 820774 [details] [review]
Github pull request

r=me, looks great and much more clear. Thanks!

Comment 7

[Kevin Grandon :kgrandon]

Thanks for the reviews!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/5311b40f07e18fb612ce80804ff16ab5010da54a

Comment 8

[Kevin Grandon :kgrandon]

Folks are requesting this be uplifted to hd? as it fixes a hd bug, so noming.

Comment 9

[Wayne Chang [:wchang]]

HD+ing for bug 907708, Kevin, can you see this uplifted to v1.1HD please?

Comment 10

[Evelyn Hung]

(In reply to Kevin Grandon :kgrandon from comment #8)
> Folks are requesting this be uplifted to hd? as it fixes a hd bug, so noming.

(In reply to Wayne Chang [:wchang] from comment #9)
> HD+ing for bug 907708, Kevin, can you see this uplifted to v1.1HD please?

I won't suggest uplift this patch, see bug 938262 comment 14

Comment 11

[Kevin Grandon :kgrandon]

(In reply to Evelyn Hung [:evelyn] from comment #10)
> (In reply to Kevin Grandon :kgrandon from comment #8)
> I won't suggest uplift this patch, see bug 938262 comment 14

Just let me know whatever you guys think is the best route. If we don't uplift this (which needs other dependent bugs), it will be hard to uplift things. I'm more than happy to help out here though - these bugs are my doing after all :)

Comment 12

[hyuna.cho]

Attachment: screenshot.png

Do not display option list on select screen.
Is there other issues?
Gaia build ver.: 5ec2963fff60492c840707df8d8090f9908a5251

Comment 13

[Kevin Grandon :kgrandon]

(In reply to hyuna.cho from comment #12)
> Created attachment 8334991 [details]
> screenshot.png
> 
> Do not display option list on select screen.
> Is there other issues?
> Gaia build ver.: 5ec2963fff60492c840707df8d8090f9908a5251

I have not tested it, but that does not look like it should be related to this patch.

Comment 14

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.