[Settings] Select elements should use pure CSS where possible

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c= p=3 s=2013.11.08 u=])

Attachments

(2 attachments)

46 bytes, text/x-github-pull-request
ivanovpavel
: review+
Evelyn Hung
: review+
Details | Review | Splinter Review
68.10 KB, image/png
Details
(Assignee)

Description

4 years ago
I've noticed that after loading a settings panel, the buttons are intially unstyled, then the styles seem to apply after the panel loads.

In addition there is quite a bit of javascript that iterates through each select after a panel loads. I think that we should move this into pure CSS if possible. I've spoken to Pavel about this in the past, but I can't remember why we didn't migrate to a CSS approach.
(Assignee)

Updated

4 years ago
Summary: [Settings] Buttons seem to "jog" after panel load → [Settings] Select elements "res-in" after panel load
(Assignee)

Comment 1

4 years ago
Created attachment 820774 [details] [review]
Github pull request
(Assignee)

Comment 2

4 years ago
Will create another bug for the flickering issue.
Summary: [Settings] Select elements "res-in" after panel load → [Settings] Select elements should use pure CSS where possible
(Assignee)

Comment 3

4 years ago
Comment on attachment 820774 [details] [review]
Github pull request

Hi Pavel - Could you give this an initial review? I would like to land this as this removes a lot of duplicated code to simply keep the fake label in sync. I don't see why we need this as we should be able to do this in pure CSS. Thanks!
Attachment #820774 - Flags: review?(pivanov)
Comment on attachment 820774 [details] [review]
Github pull request

Great job Kevin :) looks very good :)
Attachment #820774 - Flags: review?(pivanov) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 820774 [details] [review]
Github pull request

Hi Evelyn - Looking for a settings peer to review this before landing. If you have the time would you be able to take a look at this?

Thanks!
Attachment #820774 - Flags: review?(ehung)

Comment 6

4 years ago
Comment on attachment 820774 [details] [review]
Github pull request

r=me, looks great and much more clear. Thanks!
Attachment #820774 - Flags: review?(ehung) → review+
(Assignee)

Comment 7

4 years ago
Thanks for the reviews!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/5311b40f07e18fb612ce80804ff16ab5010da54a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [c= p=4 s= u=] → [c= p=3 s= u=]

Updated

4 years ago
Whiteboard: [c= p=3 s= u=] → [c= p=3 s=2013.11.08 u=]
(Assignee)

Comment 8

4 years ago
Folks are requesting this be uplifted to hd? as it fixes a hd bug, so noming.
blocking-b2g: --- → hd?
(Assignee)

Updated

4 years ago
Depends on: 908949
HD+ing for bug 907708, Kevin, can you see this uplifted to v1.1HD please?
blocking-b2g: hd? → hd+
Flags: needinfo?(kgrandon)

Comment 10

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #8)
> Folks are requesting this be uplifted to hd? as it fixes a hd bug, so noming.

(In reply to Wayne Chang [:wchang] from comment #9)
> HD+ing for bug 907708, Kevin, can you see this uplifted to v1.1HD please?

I won't suggest uplift this patch, see bug 938262 comment 14
blocking-b2g: hd+ → hd?
Flags: needinfo?(kgrandon)
(Assignee)

Comment 11

4 years ago
(In reply to Evelyn Hung [:evelyn] from comment #10)
> (In reply to Kevin Grandon :kgrandon from comment #8)
> I won't suggest uplift this patch, see bug 938262 comment 14

Just let me know whatever you guys think is the best route. If we don't uplift this (which needs other dependent bugs), it will be hard to uplift things. I'm more than happy to help out here though - these bugs are my doing after all :)

Comment 12

4 years ago
Created attachment 8334991 [details]
screenshot.png

Do not display option list on select screen.
Is there other issues?
Gaia build ver.: 5ec2963fff60492c840707df8d8090f9908a5251
Flags: needinfo?(kgrandon)
(Assignee)

Comment 13

4 years ago
(In reply to hyuna.cho from comment #12)
> Created attachment 8334991 [details]
> screenshot.png
> 
> Do not display option list on select screen.
> Is there other issues?
> Gaia build ver.: 5ec2963fff60492c840707df8d8090f9908a5251

I have not tested it, but that does not look like it should be related to this patch.
Flags: needinfo?(kgrandon)
Mass-modify - removal of no longer relevant blocking flags.

Updated

3 years ago
blocking-b2g: hd? → ---
You need to log in before you can comment on or make changes to this bug.