938262 - [B2G][Settings] Camera app permissions displays "Ask" even after a selection is made and Settings is reopened

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Darren]

Attachment: App Permissions Not Saving

Repro Steps:
1. Load Buri Build ID: 20131113004000
2. Open Settings app
3. Select "App Permissions"
4. Tap on Camera
5. Tap on the Drop-down
6. Select Grant or Deny
7. Close the app(Through the Card View)
8. Reopen Settings app and go back to the Camera App permissions

Actual Results:
The App Permission does not stay on the selection made.

Expected Results:
App Permissions will maintain the selection and will stay after closing the app and/ or a reboot.

Environmental Variables
Device: Buri v1.2 MOZ RIL
Build ID: 20131113004000
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/3fc449c858e6
Gaia: 20e8d407dac3bb2ad2616e8c2d8678d70fd82fa0
Platform Version: 26.0
Base Build: 20131104

Comment 1

[Jason Smith [:jsmith]]

I can reproduce - seems like the UI is busted with maintaining selection entities in general.

Comment 2

[Sarah Parsons]

Issues starting occurring with the permission section of the settings on the Buri 1.2 Build ID: 20130905185329. In this build (9/05) through the 9/10 1.2 build, if the user selects an app to change the permissions, the screen turns white, and the user will have to kill the settings app in the task manager, and reopen. On the 9/11 build to the present 1.2 build, the issue in comment 0 reproduces as described. 

-First Broken-
Gaia   b77dc7d399c14ac2bafe5c89566b292bc6772d32
SourceStamp df8f342e9a6b
BuildID 20130905185329
Version 26.0a1

-Last working- 
Gaia   b6c5bf1d24230bfed4a8f680e625fa2175001f82
SourceStamp 7ff96bd19c1c
BuildID 20130904040205
Version 26.0a1

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ regression

Comment 4

[bhavana bajaj [:bajaj]]

Tim, seeking help on an assignee here.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Arthur, is this part of our work? I don't think so.

The commits that touches apps/settings directory are:

Bug 901227, Bug 891743, Bug 908949, Bug 883565, Bug 910316

Kevin, would it possible if you patch triggered the regression?

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

This was regressed by bug 907708. (https://github.com/mozilla-b2g/gaia/commit/a17731400321f7fe57be1d810493fb335f9eb471)

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/13735

Evelyn, could you help review the change? Thanks!

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ah, I am not good at regression range...

Comment 9

[Evelyn Hung]

Comment on attachment 832795 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13735

in bug 907708, I suggest using `select.options[select.selectedIndex].textContent` because I want the fake button displaying "text(meaning)" instead of "value". (see bug 907708 comment 7)  But obviously I made mistake and caused the regression here.
However, I still think we should not display value on the fake button, can you also fix this too?

Comment 10

[Jason Smith [:jsmith]]

Sounds like if bug 907708 caused this means this should be uplifted to 1.1 HD.

Comment 11

[Wayne Chang [:wchang]]

regressed by 907708, which has not been landed on HD as of now yet. 

Arthur, can you check if bug 938626 will cause this regression as well? KGrandon suggests we fix 907708 by landing 938626 instead. Please NI or ping me once you confirm thanks ;)

Comment 12

[Wayne Chang [:wchang]]

Sorry I mean bug 929840 where I mentioned 938626 in my last comment.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 832795 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13735

Evelyn, I updated the patch to address the comment. Could you review it again? Thanks.

Comment 14

[Evelyn Hung]

(In reply to Wayne Chang [:wchang] from comment #11)
> regressed by 907708, which has not been landed on HD as of now yet. 
> 
> Arthur, can you check if bug 929840 will cause this regression as well?
> KGrandon suggests we fix 907708 by landing 938626 instead. Please NI or ping
> me once you confirm thanks ;)

No, I won't suggest uplift bug 929840 to fix the regression of bug 907708. 
As KGrandon commentted on bug 907708 comment 32, there are a lot of conflicts. Arthur's patch in this bug is relatively simple, it's safer, I think.

Comment 15

[Wayne Chang [:wchang]]

Thanks, lets take the patches here to address regressions from bug 907708 then.
I will remove HD+ from bug 929840.

Comment 16

[Evelyn Hung]

Comment on attachment 832795 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13735

Thanks for fixing this regression!

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 7f0b92dec4d87a7b618b628149b49a18dbd9dbc8

This issue was regressed by bug 907708, please don't uplift the patch to hd until bug 907708 gets uplifted.

Comment 18

[Jason Smith [:jsmith]]

(In reply to Arthur Chen [:arthurcc] from comment #17)
> master: 7f0b92dec4d87a7b618b628149b49a18dbd9dbc8
> 
> This issue was regressed by bug 907708, please don't uplift the patch to hd
> until bug 907708 gets uplifted.

Well, we shouldn't uplift this to 1.1 HD yet, but we should uplift it to 1.2. 1.2 does have the regressing patch in the build.

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: cc01ba1738d227dcf263ad5736cddd6925bddfbe

I was not being able to uplift to v1.2 due to conflicts.

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment 17 is wrong. The patch is for v1.2 and the bug has already been fixed on v1.2.

v1.2: 7f0b92dec4d87a7b618b628149b49a18dbd9dbc8

Comment 21

[Jason Smith [:jsmith]]

Looks fine on trunk - basic checks with the camera app w/app perms page worked as expected.