929936 - [Settings] STK will not be shown in Settings if SIM PIN is enabled and reboot device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Enpei]

Attachment: time stamp after unlock PIN and go to Settings: 17:46, 10/23.

If SIN PIN is enabled, reboot device, go check Settings, STK will not be shown. User need to terminate Settings App first after unlock PIN to make STK show again, which is not user friendly.

* Build Number                
Buri
Gaia:     00d5964eabf95a6a8a632420dfa36fc76dcbc9b7
Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/7453a764f9a9
BuildID   20131022004000
Version   26.0a2

* Reproduce Steps
1. Enable SIM PIN
2. Reboot device
3. Unlock PIN and go to Settings, finding STK

* Expected Result
STK can be found in the last item.

* Actual Result
STK is not found. Need to close Settings app in Application Manager first.

* Occurrence rate
100%

Comment 1

[Enpei]

I nominate it as koi? because user may not know why STK is not available, a complete feature not ready for user. And I don't find this problem on Ikula v1.1:

Gaia:     39b0203fa9809052c8c4d4332fef03bbaf0426fc           
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/e4cb5a852e3d      
BuildID   20131022041233                                                 
Version   18.0

Comment 2

[Preeti Raghunath(:Preeti)]

QA

Please check if this is reproducible.

Comment 3

[Tony Chung [:tchung]]

comment 1 shows its a regression from 1.1.  if devs still need a tighter regression range, please add the keywords.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

frsela, need your help on STK.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #4)
> frsela, need your help on STK.

Hi, I'll work on this asap.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

My SIM card sents me the command 37 (Main menu) also when it's PIN locked.

So I'll only work on the second part => "If a STK Application list is received when settings is opened, the settings menu will be updated"

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to update STK settings menu entry also if settings is opened

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 826733 [details] [review]
Patch to update STK settings menu  entry also if settings is opened

r=me. I left a couple minor nits on your PR.

Comment 10

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Fabien Cazenave [:kaze] from comment #9)
> Comment on attachment 826733 [details] [review]
> Patch to update STK settings menu  entry also if settings is opened
> 
> r=me. I left a couple minor nits on your PR.

Thank you Kaze,

Nits applied.

Patch landed: https://github.com/mozilla-b2g/gaia/commit/9c4352e45da0c380090a2663b6d53eaa59645f5f

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9c4352e45da0c380090a2663b6d53eaa59645f5f to:
v1.2: 3440c39f042357612e559e4fc4e050f97c8b60be

Comment 12

[Enpei]

verified on Buri v1.2

Gaia:     3cc5e6ddec0656b3a6a197e989dabebee536c982
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/ef65864c10e6
BuildID   20131110004003
Version   26.0