Closed Bug 930366 Opened 7 years ago Closed 7 years ago

detection of github PRs not working with trailing '/' in urls

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: skao, Assigned: glob)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130803192641

Steps to reproduce:

paste https://github.com/mozilla-b2g/gaia/pull/13052/ when attachment


Actual results:

won't detect as x-github-pullrequest


Expected results:

I found the detection of x-github-pullrequest requires no trailing '/' in the url,

ex. https://github.com/mozilla-b2g/gaia/pull/13052 can be detected and https://github.com/mozilla-b2g/gaia/pull/13052/ not

It would be good if urls with trailing '/' can be detected as well.
Assignee: nobody → glob
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/bin/migrate-github-pull-requests.pl
Committed revision 9095.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.