930455 - Convert nsSVGArcConverter to Moz2D

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 821624 [details] [diff] [review]
patch

Review of attachment 821624 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below.

::: content/svg/content/src/SVGPathData.cpp
@@ +394,4 @@
>          }
>        }
>        if (!subpathHasLength) {
>          subpathHasLength = (segEnd != segStart);

I think if we're comparing segEnd to segStart here, we need to run segStart through ThebesPoint(ToPoint(...)), otherwise we will be losing precision on one end but not the other, and the comparison could fail.  Is that plausible?

::: content/svg/content/src/nsSVGPathDataParser.cpp
@@ +846,5 @@
>  
>  
> +nsSVGArcConverter::nsSVGArcConverter(const Point& from,
> +                                     const Point& to,
> +                                     const Point& radii,

+1

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17156fbebbc8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17156fbebbc8