Closed
Bug 930455
Opened 13 years ago
Closed 13 years ago
Convert nsSVGArcConverter to Moz2D
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
9.23 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•13 years ago
|
||
Attachment #821624 -
Flags: review?(cam)
Comment 2•13 years ago
|
||
Comment on attachment 821624 [details] [diff] [review]
patch
Review of attachment 821624 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the below.
::: content/svg/content/src/SVGPathData.cpp
@@ +394,4 @@
> }
> }
> if (!subpathHasLength) {
> subpathHasLength = (segEnd != segStart);
I think if we're comparing segEnd to segStart here, we need to run segStart through ThebesPoint(ToPoint(...)), otherwise we will be losing precision on one end but not the other, and the comparison could fail. Is that plausible?
::: content/svg/content/src/nsSVGPathDataParser.cpp
@@ +846,5 @@
>
>
> +nsSVGArcConverter::nsSVGArcConverter(const Point& from,
> + const Point& to,
> + const Point& radii,
+1
Attachment #821624 -
Flags: review?(cam) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•