93056 - windowless plugins don't draw in the correct place when scrolled

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[David Brittain]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0b; Windows NT 5.0)
BuildID:    

When the window in which a windowless plugin is scrolled then the plugin 
redraws in the wrong place. It looks like the coordinates that are passed into 
the plugin through the nsPluginWindow parameter to SetWindow do not take 
account of the scroll offset. I suspect that this is what is being referred to 
in the code here:

http://lxr.mozilla.org/mozilla/source/layout/html/base/src/nsObjectFrame.cpp#134
6

Reproducible: Always
Steps to Reproduce:
1. Install the windowless plugin attached to bug 44322
2. Open the windowless test page attached to the same bug.
2. Reduce the size of the window until scroll bars are display.
3. Click "Move the fish"
4. Scroll down the page

Actual Results:  The plugin (green rectangular window) no longer draws in the 
same place with respect to the vertical bars on the page.

Expected Results:  Draw the plugin in the same place with respect to the 
vertical bars.

Comment 1

[Peter Lubczynski]

Hm.....this has always been a problem on Mac and we sort of cheated with
"fixing" up SetWindow() in the timer so it looks fine after a scroll. This is
related to bug 90574.

Comment 2

[Peter Lubczynski]

David, 

Can you attach a screen shot of the problem? I keep seeing the "expected
results" in that the plugin moves with the page. I'm using 0.9.2-20010727 on W2K.

Comment 3

[David Brittain]

Attachment: Picture showing problem when scrolled

Comment 4

[David Brittain]

The attached screenshot was from the 0.9.2 release (2001062815). I have also 
tried it with a recent nightly build of 0.9.2 (2001072622). And with a recent 
CVS pull of the trunk (a couple of weeks ago I think).

Comment 5

[David Brittain]

Attachment: Patch to fix incorrect draw position when scrolled

Comment 6

[chris hofmann]

anticipating that some plugin vendors are going to need this

Comment 7

[Peter Lubczynski]

looks good to me r=peterl

Comment 8

[Peter Lubczynski]

Updaing status....this is currently slated as a branch candidate.

Comment 9

[Chris Waterson]

sr=waterson

Comment 10

[Peter Lubczynski]

Fix on the trunk, do I need a plus to check in on the branch?

Comment 11

[Peter Lubczynski]

*** Bug 93500 has been marked as a duplicate of this bug. ***

Comment 12

[Peter Lubczynski]

This is a bug that Viewpoint will want fixed (dup of 93500). Nominating
topembed, nsbranch, looking for a '+'.

Comment 13

[Arun Ranganathan]

In addition, I'm nominating this nsenterprise for enterprise client check ins.

Comment 14

[shrirang khanzode]

I need help in verifying this bug on win commercial trunk. I put the basic.dll 
in plugins folder and tried the testcase. But it does not work. Does this need a 
debug build to test ? 

Comment 15

[Peter Lubczynski]

Shrirang, by following the steps to reproduce you should be able to verify.

Comment 16

[shrirang khanzode]

Since the two images mentioned in the source of the page fish.htm (fish1.gif, 
fish2.gif) are missing in thie zipped version of the file, I see alt text. 
However the behaviour seen is tha thte alt text draws exactly at the same place 
with respect to he verticle bars. So I guess, this is fixed (0813 trunk NT). 
changing status whiteboard to reflect this.

Comment 17

[David Brittain]

Sorry for the lack of input, I've been on holiday.
Unfortunately, seeing the alt text does not verify that the fix has worked - in 
this case the drawing is not being done by the plugin.
I think basic.dll should go in the components folder not the plugin folder as 
it is a new style plugin.
Once I have got a clean copy of the trunk I'll try and verify the fix.

Comment 18

[David Brittain]

Attachment: Intended testcase

Comment 19

[David Brittain]

I have attached a zip file containing the test case that I originally intended 
to be used. Sorry, for the confusion basic.dll was the wrong plugin to use. 
Install npsimple.dll in the components directory and view the html file, both 
are in the zip file.

I can verify that this bug is fixed with the latest trunk build - 2001081303 on 
Windows 2000.

Comment 20

[chris hofmann]

there doesn't seem to be anything espcially enterprisish about this bug. 
removing that keyword

Comment 21

[chris hofmann]

a=chofmann on the 0.9.2 branch.  thanks

Comment 22

[Peter Lubczynski]

Patch in branch, marking FIXED.

Comment 23

[shrirang khanzode]

verif  patch is in branch.