930641 - Remove the social.allowMultipleWorkers preference

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Florian Quèze [:florian]]

Attachment: remove-allowMultipleWorkers.patch

+++ This bug was initially created as a clone of Bug #906839 +++

The attached patch is an updated version of attachment 817770 [details] [diff] [review]. After updating it, I checked that no file in the browser/ and toolkit/components/social/ folders contained a reference to allowMultipleWorkers, and I cleaned up the 3 tests that still touched that pref.

I'm requesting review from Mark now, but we agreed this shouldn't land until mozilla-central is mozilla 28.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 821811 [details] [diff] [review]
remove-allowMultipleWorkers.patch

Review of attachment 821811 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 2

[Florian Quèze [:florian]]

Is it now time to remove this pref (the patch here has bitrotted), or do we prefer to wait another cycle?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I think we can remove this - it isn't going to be too painful in the unlikely event of needing to back this out.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

Requesting review again as the unbitrotted patch is significantly changed, but the changes were straightforward though.

Comment 5

[Florian Quèze [:florian]]

Attachment: Patch v3

Apparently I picked the wrong day to unbitrot this patch: bug 935640 landed, which means I had to unbitrot again ;).

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8348787 [details] [diff] [review]
Patch v3

simple enough, I'll r+ it.  Please do a try run before landing.

Comment 7

[Florian Quèze [:florian]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> Comment on attachment 8348787 [details] [diff] [review]
> Patch v3
> 
> simple enough, I'll r+ it.

Thanks!

> Please do a try run before landing.

Done at https://tbpl.mozilla.org/?tree=Try&rev=27924a9f250d, except for 3 known intermittent oranges, it was green.

https://hg.mozilla.org/integration/fx-team/rev/6fe9bf8ebd0b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6fe9bf8ebd0b

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Due to merge conflicts, this was backed out of Holly:

https://hg.mozilla.org/projects/holly/rev/8ff03fb178f0