Remove the social.allowMultipleWorkers preference

RESOLVED FIXED in Firefox 29

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Firefox 29
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P-][qa-][not-fixed-in-holly])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 821811 [details] [diff] [review]
remove-allowMultipleWorkers.patch

+++ This bug was initially created as a clone of Bug #906839 +++

The attached patch is an updated version of attachment 817770 [details] [diff] [review]. After updating it, I checked that no file in the browser/ and toolkit/components/social/ folders contained a reference to allowMultipleWorkers, and I cleaned up the 3 tests that still touched that pref.

I'm requesting review from Mark now, but we agreed this shouldn't land until mozilla-central is mozilla 28.
Attachment #821811 - Flags: review?(mhammond)
Comment on attachment 821811 [details] [diff] [review]
remove-allowMultipleWorkers.patch

Review of attachment 821811 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #821811 - Flags: review?(mhammond) → review+
Blocks: 935640
(Assignee)

Comment 2

4 years ago
Is it now time to remove this pref (the patch here has bitrotted), or do we prefer to wait another cycle?
I think we can remove this - it isn't going to be too painful in the unlikely event of needing to back this out.
(Assignee)

Comment 4

4 years ago
Created attachment 8348033 [details] [diff] [review]
Patch v2

Requesting review again as the unbitrotted patch is significantly changed, but the changes were straightforward though.
Assignee: nobody → florian
Attachment #821811 - Attachment is obsolete: true
Attachment #8348033 - Flags: review?(mhammond)
(Assignee)

Comment 5

4 years ago
Created attachment 8348787 [details] [diff] [review]
Patch v3

Apparently I picked the wrong day to unbitrot this patch: bug 935640 landed, which means I had to unbitrot again ;).
Attachment #8348033 - Attachment is obsolete: true
Attachment #8348033 - Flags: review?(mhammond)
Attachment #8348787 - Flags: review?(mhammond)
Comment on attachment 8348787 [details] [diff] [review]
Patch v3

simple enough, I'll r+ it.  Please do a try run before landing.
Attachment #8348787 - Flags: review?(mhammond) → review+
(Assignee)

Comment 7

4 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> Comment on attachment 8348787 [details] [diff] [review]
> Patch v3
> 
> simple enough, I'll r+ it.

Thanks!

> Please do a try run before landing.

Done at https://tbpl.mozilla.org/?tree=Try&rev=27924a9f250d, except for 3 known intermittent oranges, it was green.

https://hg.mozilla.org/integration/fx-team/rev/6fe9bf8ebd0b
https://hg.mozilla.org/mozilla-central/rev/6fe9bf8ebd0b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Whiteboard: [Australis:P-] → [Australis:P-][qa-]
Due to merge conflicts, this was backed out of Holly:

https://hg.mozilla.org/projects/holly/rev/8ff03fb178f0
Whiteboard: [Australis:P-][qa-] → [Australis:P-][qa-][not-fixed-in-holly]
You need to log in before you can comment on or make changes to this bug.