Closed Bug 930674 Opened 6 years ago Closed 6 years ago
_VISIBILITY _FLAGS to moz .build
We have a bunch of Makefile.ins that disable VISIBILITY_FLAGS by doing: VISIBILITY_FLAGS = I have patches to migrate this to moz.build by adding a boolean NO_VISIBILITY_FLAGS entry. When set to True it simply sets 'VISIBILITY_FLAGS :=' in backend.mk. I reused the passthrough variable mechanisms for this even though it's not a straight passthrough. It's a little hacky but it was easier than adding a bunch of new code.
Oops, meant to attach this first.
Attachment #821863 - Flags: review?(gps)
This is the conversion patch.
Attachment #821869 - Flags: review?(mshal)
Comment on attachment 821869 [details] [diff] [review] convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build Looks good to me!
Attachment #821869 - Flags: review?(mshal) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.