930674 - Add NO_VISIBILITY_FLAGS to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

We have a bunch of Makefile.ins that disable VISIBILITY_FLAGS by doing:
VISIBILITY_FLAGS =

I have patches to migrate this to moz.build by adding a boolean NO_VISIBILITY_FLAGS entry. When set to True it simply sets 'VISIBILITY_FLAGS :=' in backend.mk.

I reused the passthrough variable mechanisms for this even though it's not a straight passthrough. It's a little hacky but it was easier than adding a bunch of new code.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Add NO_VISIBILITY_FLAGS to moz.build

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: Add NO_VISIBILITY_FLAGS to moz.build

Oops, meant to attach this first.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build

This is the conversion patch.

Comment 4

[(not currently active) Ted Mielczarek]

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=bddd03176ff8

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 821869 [details] [diff] [review]
convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build

Looks good to me!

Comment 6

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60139be512d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce080546247

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/60139be512d4
https://hg.mozilla.org/mozilla-central/rev/4ce080546247