Closed Bug 930674 Opened 6 years ago Closed 6 years ago

Add NO_VISIBILITY_FLAGS to moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(2 files, 1 obsolete file)

We have a bunch of Makefile.ins that disable VISIBILITY_FLAGS by doing:
VISIBILITY_FLAGS =

I have patches to migrate this to moz.build by adding a boolean NO_VISIBILITY_FLAGS entry. When set to True it simply sets 'VISIBILITY_FLAGS :=' in backend.mk.

I reused the passthrough variable mechanisms for this even though it's not a straight passthrough. It's a little hacky but it was easier than adding a bunch of new code.
Attachment #821853 - Flags: review?(gps)
Oops, meant to attach this first.
Attachment #821863 - Flags: review?(gps)
Attachment #821853 - Attachment is obsolete: true
Attachment #821853 - Flags: review?(gps)
Attachment #821863 - Flags: review?(gps) → review+
Comment on attachment 821869 [details] [diff] [review]
convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build

Looks good to me!
Attachment #821869 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/60139be512d4
https://hg.mozilla.org/mozilla-central/rev/4ce080546247
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.