930849 - Add 'datareporting' field to mozinfo

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug-XXXXX-add-a-datareporting-field-to-mozinfo.-r-te.patch

At least one test specified in a Makefile.in [1] is disabled if MOZ_DATA_REPORTING isn't defined.  If mozinfo captured this it would enable the test to be added to browser.ini with a skip-if clause to express that condition.

The following patch adds a 'datareporting' field which reflects the value if this define.  Arguably, it should be 'data_reporting' to more closely match MOZ_DATA_REPORTING, but to my eyes, 'datareporting' is marginally better as it matches 'crashreporter'

[1] http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/Makefile.in#47

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 822107 [details] [diff] [review]
Bug-XXXXX-add-a-datareporting-field-to-mozinfo.-r-te.patch

Review of attachment 822107 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 822107 [details] [diff] [review]
Bug-XXXXX-add-a-datareporting-field-to-mozinfo.-r-te.patch

Review of attachment 822107 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget to document this new property in build/docs/mozinfo.rst so it shows up in the build docs at https://ci.mozilla.org/job/mozilla-central-docs/Build_Documentation/mozinfo.html#mozinfo-attributes!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Don't forget to document this new property in build/docs/mozinfo.rst so it
> shows up in the build docs at
> https://ci.mozilla.org/job/mozilla-central-docs/Build_Documentation/mozinfo.
> html#mozinfo-attributes!

Done - but I didn't bother asking for re-review for that part.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dddba67772f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3dddba67772f