Closed
Bug 930863
Opened 11 years ago
Closed 10 years ago
update CharsetLoadListener() to be e10s compliant
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 32
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: markh, Assigned: ally)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.71 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
function pageShowEventHandlers(persisted) {...} is called for a pageShow event. This calls charsetLoadListener() which has: var charset = window.content.document.characterSet; however, window.content.document is likely to be null at this point, causing browser_bug462673.js to fail. 0:09.49 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462673.js | Panel for remaining tab is selected 0:09.49 JavaScript error: chrome://browser/content/browser.js, line 13958: window.content.document is undefined
Reporter | ||
Comment 1•11 years ago
|
||
hrmph - it doesn't actually cause the test to fail, but still highlights an issue to be addressed.
Updated•10 years ago
|
tracking-e10s:
--- → +
Assignee | ||
Comment 3•10 years ago
|
||
test fails on yesterday's fx-team
Assignee | ||
Updated•10 years ago
|
Summary: browser.js pageshow handler not e10s friendly → update CharsetLoadListener() to be e10s compliant
Blocks: 1001699
Assignee | ||
Comment 4•10 years ago
|
||
test failure appears to be unrelated, bill thinks something is wrong in the order of load/unload events in the test wrt to window.close(). Filing a new bug on that
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8413018 -
Flags: review?(felipc)
Updated•10 years ago
|
Attachment #8413018 -
Attachment is patch: true
Updated•10 years ago
|
Attachment #8413018 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 6•10 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/a33ffc774df7
Whiteboard: [fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a33ffc774df7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
You need to log in
before you can comment on or make changes to this bug.
Description
•