Closed Bug 930863 Opened 6 years ago Closed 5 years ago

update CharsetLoadListener() to be e10s compliant

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 32
Tracking Status
e10s + ---

People

(Reporter: markh, Assigned: ally)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

function pageShowEventHandlers(persisted) {...} is called for a pageShow event.  This calls charsetLoadListener() which has:

  var charset = window.content.document.characterSet;

however, window.content.document is likely to be null at this point, causing browser_bug462673.js to fail.

 0:09.49 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462673.js | Panel for remaining tab is selected
 0:09.49 JavaScript error: chrome://browser/content/browser.js, line 13958: window.content.document is undefined
hrmph - it doesn't actually cause the test to fail, but still highlights an issue to be addressed.
yoink!
Assignee: nobody → ally
Status: NEW → ASSIGNED
test fails on yesterday's fx-team
Summary: browser.js pageshow handler not e10s friendly → update CharsetLoadListener() to be e10s compliant
test failure appears to be unrelated, bill thinks something is wrong in the order of load/unload events in the test wrt to window.close(). Filing a new bug on that
Attachment #8413018 - Flags: review?(felipc)
Attachment #8413018 - Attachment is patch: true
Attachment #8413018 - Flags: review?(felipc) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/a33ffc774df7
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a33ffc774df7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.