930863 - update CharsetLoadListener() to be e10s compliant

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

function pageShowEventHandlers(persisted) {...} is called for a pageShow event.  This calls charsetLoadListener() which has:

  var charset = window.content.document.characterSet;

however, window.content.document is likely to be null at this point, causing browser_bug462673.js to fail.

 0:09.49 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462673.js | Panel for remaining tab is selected
 0:09.49 JavaScript error: chrome://browser/content/browser.js, line 13958: window.content.document is undefined

Comment 1

[Mark Hammond [:markh] [:mhammond]]

hrmph - it doesn't actually cause the test to fail, but still highlights an issue to be addressed.

Comment 2

[Allison Naaktgeboren :ally]

yoink!

Comment 3

[Allison Naaktgeboren :ally]

test fails on yesterday's fx-team

Comment 4

[Allison Naaktgeboren :ally]

test failure appears to be unrelated, bill thinks something is wrong in the order of load/unload events in the test wrt to window.close(). Filing a new bug on that

Comment 5

[Allison Naaktgeboren :ally]

Attachment: fixPageShowHandlere10s

Comment 6

[Allison Naaktgeboren :ally]

remote:   https://hg.mozilla.org/integration/fx-team/rev/a33ffc774df7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a33ffc774df7