Closed
Bug 931111
Opened 12 years ago
Closed 12 years ago
[en-GB] Add Yahoo! and Bing to Fennec search engines, remove Google Reader
Categories
(Mozilla Localizations :: en-GB / English (United Kingdom), defect)
Mozilla Localizations
en-GB / English (United Kingdom)
Tracking
(firefox26+ fixed, firefox27 fixed, firefox28 fixed)
RESOLVED
FIXED
mozilla26
People
(Reporter: gueroJeff, Assigned: iannbugzilla)
References
()
Details
(Keywords: productization)
Attachments
(1 file, 1 obsolete file)
6.46 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
As discussed previously via email, please proceed to add Yahoo! and Bing to your locale's list of search engines.
Here are the instructions to do so:
For Yahoo!
- Following the guide of the en-US patch in bug 903082, please create an XML search plugin for Yahoo! and add Yahoo! to list.txt
For Bing
- Please add Bing to your list of search plugins on list.txt
Ordering:
- Please order these new search engines as follows in region.properties
1) Google
2) Yahoo!
3) Bing
As discussed before, these changes should only be seen by new users of the app and will not impact existing users. In addition, changes to the UI in Firefox 26 support the user's ability to easily change their default search engines. The link to that feature can be found in the URL field below.
Thank you for your help and understanding. As this is aimed at Firefox 26, please notify me once you have been able to have this patch approved and landed in your Aurora repos and signed-off. I will quickly approve the sign-off to ensure this is included in Firefox 26 before migration occurs.
I apologize for how late this is coming, we were only able to confirm these details today. Thank you for your participation and help with this!
Reporter | ||
Updated•12 years ago
|
status-firefox26:
--- → ?
tracking-firefox26:
--- → ?
Keywords: productization
Target Milestone: --- → mozilla26
Updated•12 years ago
|
status-firefox27:
--- → affected
status-firefox28:
--- → affected
Assignee: moz_en-gb → iann_bugzilla
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
This patch for mobile:
* Adds localised yahoo.co.uk xml file
* Adds Bing and yahoo.co.uk to the list of available search engines
Tested against fennec running on android emulator and the additional engines show up when tying in the address bar.
Attachment #827661 -
Flags: review?(jbeatty)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 827661 [details] [diff] [review]
en-GB_26_mobile_search.diff
Flagging flod for patch review.
Attachment #827661 -
Flags: review?(jbeatty) → review?(francesco.lodolo)
Comment 3•12 years ago
|
||
Comment on attachment 827661 [details] [diff] [review]
en-GB_26_mobile_search.diff
Review of attachment 827661 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/chrome/region.properties
@@ +14,5 @@
> # selection UI
> browser.contentHandlers.types.0.title=My Yahoo
> browser.contentHandlers.types.0.uri=http://add.my.yahoo.com/rss?url=%s
> browser.contentHandlers.types.1.title=Google
> browser.contentHandlers.types.1.uri=http://fusion.google.com/add?feedurl=%s
Since we're on these matters, I would be nice to drop Google Reader as well in region.properties (bug 899058)
browser.contentHandlers.types.1.title=Google
browser.contentHandlers.types.1.uri=http://fusion.google.com/add?feedurl=%s
::: mobile/searchplugins/yahoo-en-GB.xml
@@ +5,5 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Yahoo.co.uk</ShortName>
> +<Description>Yahoo UK & Ireland Search</Description>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/x-icon;base64,AAABAAEAEBAQAAEABAAoAQAAFgAAACgAAAAQAAAAIAAAAAEABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAbgJqAIoCdgCaAnoAnhKCAKYijgCuLpIAskKeALpSpgC+Yq4AzHy8ANqezgDmvt4A7tLqAPz5+wD///8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKlRFIoABWAKERERE6ADcKMzzu2hOgAAhERK8REWCWBERE36ERMHMEREvo6iEgY6hEn6Pu0mAzqkz/xjMzoDNwpERERDoAMzAKlERIoAAzMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD//wAA//8AAP//AADAOQAAgBkAAAAPAAAACQAAAAkAAAAIAAAACAAAAAgAAIAYAADAOAAA//8AAP//AAD//wAA</Image>
Use the updated icon.
@@ +11,5 @@
> + template="http://ff.search.yahoo.com/gossip?output=fxjson&command={searchTerms}" />
> +<Url type="text/html" method="GET" template="http://uk.search.yahoo.com/search">
> + <Param name="p" value="{searchTerms}" />
> + <Param name="ei" value="UTF-8" />
> + <Param name="fr" value="mozilla_mobile_search" />
Need a different MozParam here.
For both icon and this line, use en-US version as a reference
http://hg.mozilla.org/mozilla-central/file/7ba5fb33e59f/mobile/locales/en-US/searchplugins/yahoo.xml
Attachment #827661 -
Flags: review?(francesco.lodolo) → review-
Reporter | ||
Comment 4•12 years ago
|
||
Hi Ian,
The Fennec team are really anxious to get this into the Beta builds. Do you have time this week to fix the patch, land it, and sign off?
Changes made as suggested by reviewer.
Attachment #827661 -
Attachment is obsolete: true
Attachment #832380 -
Flags: review?(francesco.lodolo)
Comment 6•12 years ago
|
||
Comment on attachment 832380 [details] [diff] [review]
en-GB_26_mobile_search_v2.diff [Checked in: comment 7]
Review of attachment 832380 [details] [diff] [review]:
-----------------------------------------------------------------
Tried the patch, works fine. Please land this at least on beta and aurora with a reference to this bug and reviews (e.g. "Bug 931111: [en-GB] Add Yahoo! and Bing to Fennec search engines, remove Google Reader, r=flod")
Attachment #832380 -
Flags: review?(francesco.lodolo) → review+
Updated•12 years ago
|
Summary: [en-GB] Add Yahoo! and Bing to Fennec search engines → [en-GB] Add Yahoo! and Bing to Fennec search engines, remove Google Reader
Comment on attachment 832380 [details] [diff] [review]
en-GB_26_mobile_search_v2.diff [Checked in: comment 7]
http://hg.mozilla.org/l10n-central/en-GB/rev/024542484384
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/7e7750f56e30
http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/6fe1040c5bbf
Attachment #832380 -
Attachment description: en-GB_26_mobile_search_v2.diff → en-GB_26_mobile_search_v2.diff [Checked in: comment 7]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 8•12 years ago
|
||
Thanks Ian, please try to verify the bug with the next Beta and mark this bug as verified.
Comment 9•12 years ago
|
||
The search engines are not visible in the current Fx26 Beta 8 build. Should the patch be landed on the relbranches? I only see it on "default":
http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/graph/909
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #9)
> The search engines are not visible in the current Fx26 Beta 8 build. Should
> the patch be landed on the relbranches? I only see it on "default":
> http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/graph/909
Looking at the graph, it seems like it will be in Beta 10 build.
Comment 11•12 years ago
|
||
https://l10n.mozilla.org/shipping/signoffs/en-GB/fennec27
> Ian Neal signed off on Dec. 4, 2013; review pending
Considering the deadline was on Dec 2 to sign-off I don't see how this is going to be in the next release.
Honestly, this landed 3 weeks ago, why no sign-off?
Comment 12•12 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #11)
> Considering the deadline was on Dec 2 to sign-off I don't see how this is
> going to be in the next release.
Never mind, I was checking Aurora (fx 27) and not Beta (fx 26).
It would have been nice anyway to check that everything worked before the last beta, since there was plenty of time to sign-off.
https://l10n.mozilla.org/shipping/signoffs/en-GB/fennec26#6fe1040c5bbf
You need to log in
before you can comment on or make changes to this bug.
Description
•