931152 - gaia-ui-test: 5 tests from Master missing in branch: v1.2

Status: RESOLVED DUPLICATE of bug 919615

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Sebastiaan de Haan [:kyr0]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130917081302

Steps to reproduce:

1. Compaired the master branch at github.com/mozilla-b2g/gaia.git vs the v1.2 branch.
2. Found out that the test: test_cards_view_kill_app.py is missing from v1.2
3. Link to master branch: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view
3. Link to v1.2 branch: https://github.com/mozilla-b2g/gaia/tree/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view



Expected results:

The goal is to have the same tests in branch v1.2 as there are in the master branch.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Zac, what is the resolution here? Can we just move the tests over, or does it require code changes as well?

Comment 2

[Sebastiaan de Haan [:kyr0]]

Compaired both trees, the tests below are also missing.

test_export_contacts_to_sdcard.py
v1.3: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts
v1.2: https://github.com/mozilla-b2g/gaia/tree/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts

test_import_contacts_from_sdcard.py
v1.3: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts
v1.2: https://github.com/mozilla-b2g/gaia/tree/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts

test_sms_add_contact.py
v1.3: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages
v1.2: https://github.com/mozilla-b2g/gaia/tree/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages

test_persona_app.py
v1.3: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/persona
v1.2: https://github.com/mozilla-b2g/gaia/tree/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/persona

Comment 3

[Sebastiaan de Haan [:kyr0]]

If it is possible I would like to assist in solving this issue.

Comment 4

[Zac C (:zac)]

(In reply to Sebastiaan de Haan [:kyr0] from comment #3)
> If it is possible I would like to assist in solving this issue.

Consider it your task then! Thanks for helping out :)

Here's what you need to do:
1. Create a branch of v1.2 in Gaia name it with this bug number for ease.
2. Copy in the tests that are missing
3. Add the test names into the manifest.ini files.
4. Run the tests against v1.2 where desktopb2g allows you to (the sdcard ones won't work on desktopb2g for example). 
You can also ask us in #mozwebqa to run your branch against a device on our build server and then we can email the results and debugs to you to peruse.
You may need to make some adjustments to tests if HTML or something is not the same.

5. Once you're happy with everything, submit a pull request against the gaia 1.2 branch. Give it the title of this bug.
6. Attach a link to this bug and ask for a review on myself or someone else who works on v1.2 team and we will review and merge it if it all passes fine.

Thanks and you know where to ask if you need help ;)

Comment 5

[Sebastiaan de Haan [:kyr0]]

Attachment: [v1.2] Added missing tests from master.

Travis build: https://travis-ci.org/mozilla-b2g/gaia/builds/13228747

Comment 6

[Sebastiaan de Haan [:kyr0]]

Attachment: Bug 931152 [v1.2] Moved missing tests from master to aurora

Comment 7

[Bob Silverberg [:bsilverberg]]

This is being replaced by a number of newly opened bugs. Thanks for your efforts kyr0!