[DBus] DBusThread fails to compile on latest compilers

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bhargavg1, Assigned: bhargavg1)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [review:498808])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We see that DBusThread fails to compile on latest compilers such gcc 4.7 used in JB @following line,

https://github.com/mozilla/mozilla-central/blob/master/ipc/dbus/DBusThread.cpp#L229

with the following error,

error: cannot convert 'tag_nsresult' to 'bool' in return

+++ This bug was initially created as a clone of Bug #927459 +++

DBusThread is actually not a thread, but  a connection to the DBus service. And it doesn't really handle connections, but mostly polls file descriptors.

The name should be changed into something more meaning full, such as DBusWatcher; and the functions for handling DBusWatch structures should be converted to methods of DBusWatcher.
(Assignee)

Comment 1

4 years ago
Created attachment 822681 [details] [diff] [review]
bug_931306.patch
Attachment #822681 - Flags: review?(tzimmermann)
Attachment #822681 - Flags: review?(kyle)
Comment on attachment 822681 [details] [diff] [review]
bug_931306.patch

Review of attachment 822681 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, sorry. That was my fault. Thanks for fixing this.
Attachment #822681 - Flags: review?(tzimmermann) → review+
(Assignee)

Updated

4 years ago
blocking-b2g: --- → 1.3?
(Assignee)

Comment 3

4 years ago
checkin-needed
Whiteboard: [review:498808]
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
blocking-b2g: 1.3? → ---
https://hg.mozilla.org/integration/b2g-inbound/rev/df9698b7309f
Assignee: nobody → bhargavg1
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df9698b7309f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.