931670 - If the voice and data can not concurrent existed, we should change data connection state to "SUSPEND" during voice call.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Enpei]

Attachment: time stamp: 11:48~11:50.

+++ This bug was initially created as a clone of Bug #909689, used for tracking device still keeps trying opening web page during the voice call part +++

Data call should be dropped during voice call, yet on wasabi, if trying to open a website, it's not showing error due to no internet, instead it shows loading progress bar underneath URL bar, which might indicate system is still trying to access data call(?).

* Build Number                
Gaia:     14f3f4e7b65ff79ef131ce4d3a8a3e45cab2d9d9
Gecko:    e73f8571b58fe0313823138de72a3e80ce726cad
BuildID   20131028031555
Version   26.0a2

* Reproduce Steps
1. Data call is connected.
2. MO a call.

* Expected Result
Soon user can get error message page like offline mode right after trying to access data call during voice call.

* Actual Result
It shows loading progress bar underneath URL bar, which might indicate system is still trying to access data call.

* Occurrence rate
100%.

Comment 1

[Enpei]

Hi Ken,

Could you help to double check if this is modem issue? If so, I will set it as POVB bug.

Comment 2

[Ken Chang[:kenkai]]

1. Data connection is activated.
10-28 11:48:23.033 I/Gecko   (  666): -*- RILContentHelper: Received message 'RIL:DataInfoChanged': {"clientId":0,"data":{"connected":true,"emergencyCallsOnly":false,"roaming":false,"network":{"longName":"46605","shortName":"","mcc":"466","mnc":"05"},"cell":{"gsmLocationAreaCode":-1,"gsmCellId":-1},"type":"evdob","signalStrength":-59,"relSignalStrength":100,"state":"registered","apn":"aptnet"}}

2. Try to make a call here.
10-28 11:48:29.080 I/Gecko   (  200): RIL Worker[0]: Received chrome message {"number":"117","isDialEmergency":false,"rilMessageToken":19,"rilMessageType":"dial"}

3. We don't get DataInforChanged until 11:50:58.158. But this message still tell device that data call is available.
10-28 11:50:58.158 I/Gecko   (  730): -*- RILContentHelper: Received message 'RIL:DataInfoChanged': {"clientId":0,"data":{"connected":true,"emergencyCallsOnly":false,"roaming":false,"network":{"longName":"46605","shortName":"","mcc":"466","mnc":"05"},"cell":{"gsmLocationAreaCode":-1,"gsmCellId":-1},"type":"evdob","signalStrength":-59,"relSignalStrength":100,"state":"registered","apn":"aptnet"}}

It seems that modem doesn't update the current data network status to us. I think the best way is that modem should provide a network update to us. But I wonder if they would do it.
@Edgar, is it possible for we to get data network status when user is making a call in CDMA network? Is it a good method?

Comment 3

[Edgar Chen [:edgar]]

After checking log deeply, I found when device is in call, the data call status changes to "active/physical link down" [1]. And currently we map this to GECKO_NETWORK_STATE_CONNECTED [2]. Maybe we should not treat this status as "Connected".

Here I am going to do:
1). Test with N970 to make sure this behavior.
2). Figure out does AOSP handle this case? how to?

Thank you.

[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L213
[2] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#l3818

(Keep ni? for tracking)

Comment 4

[Enpei]

Attachment: Time stamp: 10:06, 11/22

QCRIL has no such bug, please check the log.

Comment 5

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> After checking log deeply, I found when device is in call, the data call
> status changes to "active/physical link down" [1]. And currently we map this
> to GECKO_NETWORK_STATE_CONNECTED [2]. Maybe we should not treat this status
> as "Connected".
> 
> Here I am going to do:
> 1). Test with N970 to make sure this behavior.
> 2). Figure out does AOSP handle this case? how to?
> 
> Thank you.
> 
> [1]
> https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/
> telephony/ril.h#L213
> [2]
> http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.
> js?from=ril_worker.js#l3818
> 
> (Keep ni? for tracking)

After checking the AOSP implementation, if the voice and data can not concurrent existed, AOSP will change data state to "SUSPEND" [1], and AOSP will remove all routing of the network when it becomes to "SUSPEND" [2].

[1] http://androidxref.com/source/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/cdma/CDMAPhone.java#628
[2] http://androidxref.com/source/xref/frameworks/base/services/java/com/android/server/ConnectivityService.java#2710

Comment 6

[Josh Cheng [:josh]]

Hi Wesley,
This bug is also reported by partner at woodduck in bug 1082471. Bug 1082471 will be temporary solution for 2.0M. After I discussed with Shawn, we strongly think this should be 2.1+. Could you please have a check?
Thanks!

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Blocking Requested - why for this release]:
Per comment 0, this could be a confusing user flow.
Per comment 6, partner is reporting issue on device branch.

I'm not sure if this should block. 
Let's have triage to determine.

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: it's a new feature as previous versions are having the same behavior.
it's not blocking and let's propose to 2.2? as feature.

Comment 9

[Edgar Chen [:edgar]]

Unassigning myself as I am no longer working on this.

Comment 10

[BMO Automation]

Firefox OS is not being worked on