93170 - OSX: animated gifs have lines through center with plugin on page

Status: VERIFIED DUPLICATE of bug 137295

(Core :: Graphics: ImageLib, defect, P2)

Description

[Chris Petersen]

Build: 2001080105
Platform: Mac OS X
Expected results: No paint problem inside or around table
What I got: Banners ads at the top and bottom of table are not completely painted.

Steps to reproduce:

1) Go to http://www.macshowlive.com/archive.html
2) Reduce the size of the window.
3) Notice portions of top /bottom ads are not painted properly. Small gif (upper
right of table) appears outside of table.
4) I can't reproduce this painting problem under Mac OS 9.1.

Comment 1

[Chris Petersen]

Attachment: screen shot of problem

Comment 2

[karnaze (gone)]

We need a reduced test case.

Comment 3

[Chris Petersen]

I spent some researching this issue noticed the "stream" buttons are actually qt
movies that have their controllers hidden.  If you replace these four QT movies
with images (download.jpg), the painting issue doesn't reproduce when resizing
the window.

Comment 4

[Chris Petersen]

Attachment: QT movies removed and replaced by jpg images

Comment 5

[Chris Petersen]

Peter, 

Can you take a look at this ?

Comment 6

[Peter Lubczynski]

This is likely my bug if it only happens on OS X, but I think it could be a dup. 

Petersen, can you attach a minimal testcase? Thanks!

Comment 7

[Chris Petersen]

Attachment: a simple page with QT movie and animated gif

Comment 8

[Chris Petersen]

Changed summary since problem isn't table related

Comment 9

[Chris Petersen]

Further reduced test case. Align = center removed. Problem still occurs  when
resizing window.

Comment 10

[Chris Petersen]

Attachment: Align removed from QT movie

Comment 11

[Chris Petersen]

Problem occurs with Flash object and animated gifs as well. See warner test
case. When window is resized painting issue appears on gifs

Comment 12

[Chris Petersen]

Attachment: warner bros.com test case; flash and animated gif in page

Comment 13

[Peter Lubczynski]

images don't paint--->imagelib/pavlov

Comment 14

[Chris Petersen]

Is anyone actively looking at this bug ? This problem is ugly and occurs on
various pages including warner's bros site.

Comment 15

[lchiang]

nominate nsbranch and cc: nisheeth.

Comment 16

[Stuart Parmenter]

This works fine on windows.  I don't have a mac to test it on..  I will get 
together with someone with OSX to try and reproduce this and figure out what is 
going on.

If I had to guess, I expect there is something bad going on with timers and 
events on OSX that is causing the animation timers not to get fired.

Comment 17

[Mike Pinkerton (not reading bugmail)]

cc'ing bnesse. brian, doesn't this sound like the same problem as weather.com 
that i've been hounding you about for months? ;)

Comment 18

[Brian Nesse (gone)]

That would be bug 76085. If indeed this is a dup it is not OSX only, simply Mac
only.

Comment 19

[Peter Lubczynski]

I think bug 76085 is a little different. Attachment #47273 [details] shows a very simple
testcase with a white band through the middle of the image when the image is not
animating or the window is being resized.

Also, a single click anywhere in the plugin causes the white band to be painted.
My guess is that the plugin is painting outside it's area because the clip isn't
set correctly, possibly in ProcessEvent. Reassiging back to myself....

Comment 20

[Chris Petersen]

I would like to see this resolved since it happens to affect sites that have
both flash or QT content with animated gifs on the same page. Warners bros site
has this issue on several pages. Problem only occurs under Mac OS X.

http://www2.warnerbros.com/web/movies/index.jsp?frompage=http%253A%252F%252Fwww.dccomics.com
http://www2.warnerbros.com/web/main/index.jsp
http://www2.warnerbros.com/web/wboriginals/index.jsp?frompage=nav
http://www.warnerbros.com/pages/kids/home.jsp?fromtout=home_menu_kids_item0
http://www.warnerbros.com/pages/community/home.jsp
http://shopping.warnerbros.com/
http://looneytunes.warnerbros.com/web/looney_library/home.jsp?frompage=kids
http://looneytunes.warnerbros.com/web/looney_library/library_story.jsp

Comment 21

[lchiang]

bug http://bugzilla.mozilla.org/show_bug.cgi?id=76085 (which folks suspect this
is a duplicate of) mentions that layout folks' help is needed.

Because some internal sites are affected, I wonder if this will come back to
haunt us. I will inquire.

Comment 22

[Chris Petersen]

Similar problem occurs on static GIF 89A so it's not just animated gifs

http://www.tnt.tv/index.html

Resizing window will should problem in the "TNT Spotlight" section.

Comment 23

[Chris Petersen]

Attachment: TNT sample

Comment 24

[Chris Petersen]

Take a look at the TNT sample test. Contains a static GIF89a image and flash
embed element. If you resize the page so that only the gif is visible, it
renders properly. The both the flash object and the gif are both visible , the
gif renders incorrectly.

Comment 25

[Chris Petersen]

If you scale the image via HTML by a pixel (larger or smaller), the problem no
longer occurs either. I have added another test case to show this.

Comment 26

[Chris Petersen]

Attachment: Modified test with scaling being applied on two of three images

Comment 27

[Simon Fraser [no longer active]]

Does today's build (branch or trunk) show this problem?

Comment 28

[Chris Petersen]

Yes, the Mac OS X 2001-09-28-04-0.9.4 build is showing the problem still.

Comment 29

[Jaime Rodriguez, Jr.]

dagley - there weren't any comments in this bug, on why it received an OSX- ...
seeking a little guidance here ...

Comment 30

[Chris Petersen]

Guess what ? I noticed this problem only happens when the monitor bit depth is
millions. I couldn't reproduce this problem on my iBook which was set to
thousands. Setting the LCD to millions would immediately cause problem. Tried
this out on my G4/450 running 10.1 and verified that thousands of colors mode
solves problem. 

Comment 31

[lchiang]

That's good to hear.  What is the default setting on Macs when purchased?
Chris - this may be a good item to add to the release notes tracking bug for
folks to try.  

I thought I had seen a similar problem filed before.  I will have to look to see
if I can find it.

Comment 32

[Brian Nesse (gone)]

> What is the default setting on Macs when purchased?
Millions...

Comment 33

[Peter Lubczynski]

I tried some extra "fixing up" of the plugin window plus saving off the GrafPort
with no luck.

Upon a closer look with attachment 47322 [details] which has a yellow background, I know
the plugin is NOT painting on top of the animated gif. Maybe the problem is in
image code instead of plugin code.

I'll keep looking but it's difficult without being able to set breakpoints. The
lastest CW7 on macdev does not stop on my breakpoints.

Comment 34

[Peter Lubczynski]

...back over to Pavlov because I think it could be a problem in image code....if
not and it's something with plugins, feel free to send back to me...

Comment 35

[Stuart Parmenter]

-> future.  I'm not going to have time to look at this anytime soon.  I don't
have a mac to test this on.

Comment 36

[Chris Petersen]

I really don't like the fact that this issue has been futured. OS X users will
see this problem since it happens on a variety of pages listed. I'm sure if this
was happening on our own netscape page, we would spend time to resolve it.
However, it's happening on several warner bros sites since that combine flash
and gifs on the same page.

Comment 37

[Chris Petersen]

ESPN main page has the same problem as described:
http://msn.espn.go.com/main.html

Comment 38

[Chris Petersen]

On the EPSN site, a gap is drawn over the MSN header logo and the video
highlight (animated gif) add which is positioned to the right of the ESPN
navigation bar.

Comment 39

[Mike Pinkerton (not reading bugmail)]

pav won't be of much help here. giving to saari who might actually care.

Comment 40

[Chris Petersen]

Removing - from nsbranch since it's occuring on additional sites. See my
previous comments listed.

Comment 41

[Chris Petersen]

Disney's go site has this problem on the top banner ad :


http://disney.go.com/park/homepage/today/flash/index.html

Comment 42

[Terri Preston]

I also see this problem at www.planetofmusic.com (I don't think users will 
easily figure out to change their settings to thousands and therefore will 
continuously run into this bug)

Comment 43

[Jaime Rodriguez, Jr.]

Was this renominated in hopes that it will make 094 for OSX? 

Comment 44

[Chris Petersen]

My goal was to have this further discussed by PDT. This painting problem is very
noticeable when monitor color depth is set to millions under OS X (which is the
default). Espn , Disney, and Warner Bros sites are listed in our top 100 so I
concerned that the majority of OS X users will see these painting issues.

Comment 45

[Jaime Rodriguez, Jr.]

k ... Adding PDT to Status Whiteboard for further discussion.

Comment 46

[saari (gone)]

I also can't reproduce on 9.1. I'll need an OS X box to get anywhere with this.
Can't think of a reason why we'd have animated GIF issues on X and not on 9.

Comment 47

[Chris Petersen]

Yes, you won't see this problem under 9.1. Also, the problem happens mostly with
animated gifs but does occasionly occur on static GIF. The TNT site shows a
painting issue with the four gifs in the "TNT" spotlight section.
http://www.tnt.tv/index.html

Comment 48

[Jaime Rodriguez, Jr.]

can you look into this with saari.

no pacth. PDT-

Comment 49

[lchiang]

petersen - I tried a few test cases here:
http://www.macshowlive.com/archive.html
http://www.tnt.tv/index.html
http://looneytunes.warnerbros.com/web/looney_library/library_story.jsp
http://shopping.warnerbros.com/
and then resized my window and I don't see paint problems.

I am on an iMac, OS 10.0.4, millions of colors, 1024x768

Comment 50

[lchiang]

tpreston pointed out to me that sites change their ads so I may not see the
problem all the time.

I tried petersen's reduced test case at
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=47273.  When I resize
the window, I do see that part of the current ad blanks out slightly until the
next ad draws/appears.  If we normally see this problem on banner ads, it
appears that the problem gets corrected when the next ad gets served.  Is this
your observation?

Comment 51

[Chris Petersen]

Lisa,

I have noticed the animated gif banners can correct themselves when the next
image in the sequence loads. But isn't always the situation. Sometimes the
second and third image in the sequence will have the gap in them. If the problem
is resolved by loading another image, you will see the problem again if the
problem is window resized again (while the image is displayed) See "wb" attachment.

Another related issue is that some animated gifs appear to partially tile. This
was noticeable at one of the warner sites. See "wb2" attachment. The problem
(bug gif in center of page)isn't fixed when the next image in the that sequence
is loaded.


Static gifs can be displayed with portions missing. See "tnt" attachment. There
isn't a way this can be corrected except to change colors to thousands.

Comment 52

[Chris Petersen]

Attachment: Gaps appear in both static and animated gifs

Comment 53

[Chris Petersen]

Attachment: Gif image appears to be partially tiled

Comment 54

[Chris Petersen]

Attachment: Static gifs are missing portions of image

Comment 55

[Chris Petersen]

Tested on Mac OS X 10.1, iBook, Millions, 1024 x 768

Comment 56

[Peter Lubczynski]

*** Bug 108866 has been marked as a duplicate of this bug. ***

Comment 57

[Jaime Rodriguez, Jr.]

Removing PDT grafitti from Status Whiteboard.

Comment 58

[mozilla]

I made a Web page demonstrating this bug in a very simple context:
http://segal.org/blankbar/index.html
It was used for bug 108866, which has been marked as a duplicate of this bug.  
The page has a simple example and full source code in a link.

Comment 59

[Steve Dagley]

taking bug so saari's head doesn't expolde
targeting 098 since it won't make 097

Comment 60

[Chris Petersen]

Added Applet to summary.

Comment 61

[Chris Petersen]

Here is one of Apple's site where the problem occurs.
(http://www.apple.com/quicktimelive/why.html)

The page contains a QT movies and noticeable gap appears in the Quicktime Live
image and Top Reasons to Attend image.

Any progress on getting this resolved ? 

Comment 62

[Steve Dagley]

Unfortunately not.  The hope was that pav's timer rewrite would change this 
behavior since it affects how animated images are drawn but that appears not to 
be the case.

And just noting some additional info.  The segal.org test page exhibits the 
problem event when you don't have the Carbon MRJ plugin installed so it happens 
even without the plugin actually being instantiated

Comment 63

[Steve Dagley]

Chris,

On a related note, any problems accessing <http://www.apple.com/quicktimelive/
why.html> from the Classic Mac OS Mozilla build?  Running the Carbon Mozilla 
build under Mac OS 9.2.2 results in a crash accessing that page.

Comment 64

[Chris Petersen]

Let me download that version and reboot under OS 9.2.1.

Comment 65

[Chris Petersen]

I didn't experience a crash when loading this page under OS 9.2.1. Tested with
the Jan 3rd build (2002-01-03-04). I have QT 5.0.2 installed but after loading
the page I got a message that said I needed to update QT for a (QT Channels)
component. I clicked OK and it got installed. 

Comment 66

[Steve Dagley]

--> 0.9.9

Comment 67

[Chris Petersen]

Here is another site that shows the problem:

http://www.shockwave.com/sw/games/

Gaps appear in the various headings like action -adventure, shooters, 3d games,
multiplayer, puzzle games, etc...

Comment 68

[Peter Lubczynski]

Repharsing summary from: [If a page contains QT/Flash/Applet object and animated
gif, a paint problem will occur when the win]

Comment 69

[Chris Petersen]

Adding nsbeta1

Comment 70

[Chris Petersen]

Changing Priority to P2. Noticing this issue occurs on Disney's site. 
Open any of these url and resize the window. Notice gaps appear in the left
aligned sidebar image.

http://disneyland.disney.go.com/disneylandresort/Disneyland/index?id=227

http://disneyland.disney.go.com/disneylandresort/Disneyland/Lands/index?id=DLPAdventureland

http://disneyland.disney.go.com/disneylandresort/Disneyland/Lands/index?id=DLPFrontierland

http://disneyland.disney.go.com/disneylandresort/Disneyland/Lands/index?id=DLPFantasyland

Comment 71

[Chak Nanga]

plusing - ADT/Embedding triage team.

Comment 72

[Steve Dagley]

-> mozilla1.0

Comment 73

[Chris Petersen]

Nominating for topembed

Comment 74

[Simon Fraser [no longer active]]

Hunch: the CopyBits that copies from one image frame to the next
(nsImageMac::CopyToImage or somesuch) is being clipped by the clipping of the
(implicit) current port, which has been set by plugins. Maybe.

Comment 75

[Peter Lubczynski]

*** This bug has been marked as a duplicate of 137295 ***

Comment 76

[Terri Preston]

Verified Duplicate