931726 - [HW test] change recording test to gUM test, remove audioloop test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tom Jao [:mbrsl]]

Since the recording test in UItest is outdated. And it's quite similar to getUserMedia test (http://mozilla.github.io/webrtc-landing/gum_test.html). I decide to use it for template and add into UItest.

Comment 1

[Tom Jao [:mbrsl]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13277

Comment 2

[[e-mail]]

SC, 
I saw you have some extra items for gUM test
http://people.mozilla.org/~schien/gum-test.html

is there any items worth to add to uitest?

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I think we can add the following two cases in uitest:
1. Using MediaStreamConstraint to only get back or front camera
2. Provide a extra "Get Audio" to request audio channel for multiple times.

Comment 4

[[e-mail]]

Thanks SC

1. sounds could be done in video/option list related patch, since it's not happened yet

2. It's worth to add for bug 907075 test case

Tom, could you refer http://people.mozilla.org/~schien/gum-test.html and add 2nd case in this patch?

the order might be
 
video
video 2
audio
audio 2
audio & video
audio & video 2
picture

Comment 5

[Tom Jao [:mbrsl]]

OK, I'll try it at the end of next week.

Is there any other reference about gUM? The documentation on MDN https://developer.mozilla.org/en-US/docs/Web/API/Navigator.getUserMedia seems to be outdated. Constrains like picture and front camera are not mentioned in the documentation.

Comment 6

[[e-mail]]

Tom, picture and front camera are currently not support in gaia/gecko for FxOS ... So it's fine not add front camera or picture in uitest

Comment 7

[[e-mail]]

Comment on attachment 825726 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13277

feel free to add review sign again once you modified the patch, thanks

Comment 8

[Tom Jao [:mbrsl]]

I refactor this test so that it can call several gUM calls without closing previous request.
For bug 907075, I add a double prompt button which makes two successive gUM requests but does nothing after success.

Also, I found that this test is much powerful than HW/Audio loop test which only use the voice part of gUM. So I remove the audioloop test.

Comment 9

[[e-mail]]

Comment on attachment 825726 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13277

Thanks TOM. It looks good to me.

please check github comment, ping me when you are ready to merge code

Comment 10

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/50e3c24ee94e74903ce005487aa2baaaa0c76897

thanks!