Closed Bug 931726 Opened 6 years ago Closed 6 years ago

[HW test] change recording test to gUM test, remove audioloop test

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tjao, Assigned: tjao)

References

Details

Attachments

(1 file)

Since the recording test in UItest is outdated. And it's quite similar to getUserMedia test (http://mozilla.github.io/webrtc-landing/gum_test.html). I decide to use it for template and add into UItest.
Assignee: nobody → tjao
Blocks: eng-mode
Attachment #825726 - Flags: review?(flin)
SC, 
I saw you have some extra items for gUM test
http://people.mozilla.org/~schien/gum-test.html

is there any items worth to add to uitest?
Flags: needinfo?(schien)
I think we can add the following two cases in uitest:
1. Using MediaStreamConstraint to only get back or front camera
2. Provide a extra "Get Audio" to request audio channel for multiple times.
Flags: needinfo?(schien)
Thanks SC

1. sounds could be done in video/option list related patch, since it's not happened yet

2. It's worth to add for bug 907075 test case

Tom, could you refer http://people.mozilla.org/~schien/gum-test.html and add 2nd case in this patch?

the order might be
 
video
video 2
audio
audio 2
audio & video
audio & video 2
picture
OK, I'll try it at the end of next week.

Is there any other reference about gUM? The documentation on MDN https://developer.mozilla.org/en-US/docs/Web/API/Navigator.getUserMedia seems to be outdated. Constrains like picture and front camera are not mentioned in the documentation.
Tom, picture and front camera are currently not support in gaia/gecko for FxOS ... So it's fine not add front camera or picture in uitest
Comment on attachment 825726 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13277

feel free to add review sign again once you modified the patch, thanks
Attachment #825726 - Flags: review?(flin)
Attachment #825726 - Flags: review?(flin)
I refactor this test so that it can call several gUM calls without closing previous request.
For bug 907075, I add a double prompt button which makes two successive gUM requests but does nothing after success.

Also, I found that this test is much powerful than HW/Audio loop test which only use the voice part of gUM. So I remove the audioloop test.
Summary: [HW test] change recording test to gUM test → [HW test] change recording test to gUM test, remove audioloop test
Comment on attachment 825726 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13277

Thanks TOM. It looks good to me.

please check github comment, ping me when you are ready to merge code
Attachment #825726 - Flags: review?(flin) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/50e3c24ee94e74903ce005487aa2baaaa0c76897

thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.