931785 - sport24.gr doesn't redirect to mobile site on Firefox OS

Status: RESOLVED INVALID

(Web Compatibility :: Mobile, defect)

Description

[Thanos Lefteris [:alefteris]]

Site: http://www.sport24.gr
sport24.gr doesn't redirect to mobile site on Firefox OS

:: Steps To Reproduce

1. Open Firefox OS browser
2. Type sport24.gr in Firefox OS browser

:: Expected Result

Get redirected to http://m.sport24.gr. When typing the Web site address on Firefox for Android or iOS Safari we get redirected to the mobile site.

:: Actual Result

We receive the desktop site of http://www.sport24.gr

:: Additional Information

Software Version: Mozilla/5.0 (Mobile; rv:26.0) Gecko/26.0 Firefox/26.0
Device Information: Keon

Comment 1

[Mike Taylor [:miketaylr]]

In http://24media.gr/en/article1908010.ece/BINARY/original/js-utils.js,

ui.mobile.detect.Frame.prototype.check=function(){if(this.isMobile(navigator.userAgent)){if(Cookie.get("edition_preference")&&Cookie.get("edition_preference")=="desktop"){this.display.call(this)
}else{return"http://"+this.domain+"/redirect?search="+encodeURIComponent(window.location.href)
}}return null
};
...
ui.mobile.detect.Frame.prototype.isMobile=function(b){var a={Android:function(){return b.match(/Android/i)?true:false
},BlackBerry:function(){return b.match(/BlackBerry/i)?true:false
},iOS:function(){if(b.match(/iPad/i)){return false
}return b.match(/iPhone|iPod/i)?true:false
},Windows:function(){return b.match(/IEMobile/i)?true:false
}};
return(a.Android()||a.BlackBerry()||a.iOS()||a.Windows())
};

So we need them to add perhaps a generic "mobile" inside their isMobile. We probably don't want to add a UA override here as android because then we'll get a useless Google Play ad:


<script src="/static/smartbanner/jquery.smartbanner.js"></script>
		<script type="text/javascript">
			$.smartbanner({
			title: null, // What the title of the app should be in the banner (defaults to <title>)
			author: null, // What the author of the app should be in the banner (defaults to <meta name="author"> or hostname)
			price: 'FREE', // Price of the app
			appStoreLanguage: 'us', // Language code for App Store
			inAppStore: 'On the App Store', // Text of price for iOS
			inGooglePlay: 'ΚΑΤΕΒΑΣΕ ΤΗΝ ΕΦΑΡΜΟΓΗ', // Text of price for Android

Comment 2

[Mike Taylor [:miketaylr]]

Here's a drop-in replacement they can use: https://gist.github.com/anonymous/7199832

Comment 3

[Hallvord R. M. Steen [:hallvors]]

Attachment: Screenshot from Flame smartphone

Comment 4

[Karl Dubost💡 :karlcow]

Invalid sport24 seems to not have anymore a mobile site.