Closed Bug 931899 Opened 7 years ago Closed 5 years ago

[meta] News247.gr js-utils script fails to recognize B2G UA as mobile

Categories

(Web Compatibility :: Mobile, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: miketaylr, Assigned: karlcow)

References

Details

(Whiteboard: [country-gr][clientsniff][sitewait])

In http://24media.gr/en/article1908010.ece/BINARY/original/js-utils.js,

ui.mobile.detect.Frame.prototype.check=function(){if(this.isMobile(navigator.userAgent)){if(Cookie.get("edition_preference")&&Cookie.get("edition_preference")=="desktop"){this.display.call(this)
}else{return"http://"+this.domain+"/redirect?search="+encodeURIComponent(window.location.href)
}}return null
};
...
ui.mobile.detect.Frame.prototype.isMobile=function(b){var a={Android:function(){return b.match(/Android/i)?true:false
},BlackBerry:function(){return b.match(/BlackBerry/i)?true:false
},iOS:function(){if(b.match(/iPad/i)){return false
}return b.match(/iPhone|iPod/i)?true:false
},Windows:function(){return b.match(/IEMobile/i)?true:false
}};
return(a.Android()||a.BlackBerry()||a.iOS()||a.Windows())
};

This script is present in a number of popular Greek news sites. Fixing it at the source should help Firefox OS get the correct mobile version.

Suggested fix: https://gist.github.com/anonymous/7199832
Blocks: 931816, 931808, 931785
Whiteboard: [country-gr][clientsniff][contactready]
Blocks: 931919
I send a message mentioning all affected sites using the contact form at http://24media.gr/el/contact/
The new contact page is 
http://www.24media.gr/contact/
It contains an email address info @ 24media.gr. But I doubt it would be more effective than what Thanos already tried. Maybe we can find a human contact. Let's see.

http://twitter.com/MozWebCompat/status/456597084867538944
Assignee: nobody → kdubost
Whiteboard: [country-gr][clientsniff][contactready] → [country-gr][clientsniff][sitewait]
To be more explicit this is impacting:

* Bug 931785 sport24.gr
* Bug 931808 news247.gr
* Bug 931816 contra.gr
* Bug 931919 redplanet.gr
Status: NEW → ASSIGNED
Thanks for pointing out the issue, we have assigned it, let you know of the progress.
Thanks dx. We are looking forward a solution.
If you had missed the suggested fix, here it is.
https://gist.github.com/anonymous/7199832
Flags: needinfo?(dx)
This is still an issue today.
@dx

Any progress on this issue?
Recontacted on twitter too.
I am not at 24 Media anymore so cannot help directly, but I have reminded them of the pending issue.
Flags: needinfo?(dx)
They also have a very NON active account on github :) https://github.com/24Media
other candidates: 
https://twitter.com/_Delalis
https://twitter.com/helenrow21
https://twitter.com/manmihalos
Trying to contact by email
https://github.com/blxbrgld
24Media is not using this script anymore for devices detection.
I'm closing as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.