931899 - [meta] News247.gr js-utils script fails to recognize B2G UA as mobile

Status: RESOLVED FIXED

(Web Compatibility :: Mobile, defect)

Description

[Mike Taylor [:miketaylr]]

In http://24media.gr/en/article1908010.ece/BINARY/original/js-utils.js,

ui.mobile.detect.Frame.prototype.check=function(){if(this.isMobile(navigator.userAgent)){if(Cookie.get("edition_preference")&&Cookie.get("edition_preference")=="desktop"){this.display.call(this)
}else{return"http://"+this.domain+"/redirect?search="+encodeURIComponent(window.location.href)
}}return null
};
...
ui.mobile.detect.Frame.prototype.isMobile=function(b){var a={Android:function(){return b.match(/Android/i)?true:false
},BlackBerry:function(){return b.match(/BlackBerry/i)?true:false
},iOS:function(){if(b.match(/iPad/i)){return false
}return b.match(/iPhone|iPod/i)?true:false
},Windows:function(){return b.match(/IEMobile/i)?true:false
}};
return(a.Android()||a.BlackBerry()||a.iOS()||a.Windows())
};

This script is present in a number of popular Greek news sites. Fixing it at the source should help Firefox OS get the correct mobile version.

Suggested fix: https://gist.github.com/anonymous/7199832

Comment 1

[Thanos Lefteris [:alefteris]]

I send a message mentioning all affected sites using the contact form at http://24media.gr/el/contact/

Comment 2

[Karl Dubost💡 :karlcow]

The new contact page is 
http://www.24media.gr/contact/
It contains an email address info @ 24media.gr. But I doubt it would be more effective than what Thanos already tried. Maybe we can find a human contact. Let's see.

http://twitter.com/MozWebCompat/status/456597084867538944

Comment 3

[Karl Dubost💡 :karlcow]

To be more explicit this is impacting:

* Bug 931785 sport24.gr
* Bug 931808 news247.gr
* Bug 931816 contra.gr
* Bug 931919 redplanet.gr

Comment 4

[dx]

Thanks for pointing out the issue, we have assigned it, let you know of the progress.

Comment 5

[Karl Dubost💡 :karlcow]

Thanks dx. We are looking forward a solution.
If you had missed the suggested fix, here it is.
https://gist.github.com/anonymous/7199832

Comment 6

[Mike Taylor [:miketaylr]]

This is still an issue today.

Comment 7

[Karl Dubost💡 :karlcow]

@dx

Any progress on this issue?

Comment 8

[Karl Dubost💡 :karlcow]

Recontacted on twitter too.

Comment 9

[Karl Dubost💡 :karlcow]

http://twitter.com/MozWebCompat/status/526697372232216577

Comment 10

[dx]

I am not at 24 Media anymore so cannot help directly, but I have reminded them of the pending issue.

Comment 11

[Karl Dubost💡 :karlcow]

Trying higher up
http://twitter.com/MozWebCompat/status/560327686757707778

Comment 12

[Karl Dubost💡 :karlcow]

They also have a very NON active account on github :) https://github.com/24Media
other candidates: 
https://twitter.com/_Delalis
https://twitter.com/helenrow21
https://twitter.com/manmihalos

Comment 13

[Karl Dubost💡 :karlcow]

Trying http://twitter.com/MozWebCompat/status/666916083601793024

Comment 14

[Karl Dubost💡 :karlcow]

Trying to contact by email
https://github.com/blxbrgld

Comment 15

[Karl Dubost💡 :karlcow]

24Media is not using this script anymore for devices detection.
I'm closing as FIXED.