931926 - Please schedule cpp unittests on Try

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dan Minor [:dminor]]

There are a pair of cpp unittests which fail consistently on Cedar: see bug 931062 and bug 929985.

These could be resolved through the use of loaner machines, but being able to run them on try would make facillitate developer involvement and would be another step towards being able to remove cpp unittests from make check.

The visibility for these should be hidden for now.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: WIP patch

I assume you still want this too?

cpp unittests enabled on opt but not for fedora, fedora64 https://bugzilla.mozilla.org/show_bug.cgi?id=912192

Comment 2

[Dan Minor [:dminor]]

kmoir, matching the current scheduling on Cedar should be fine.

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 824286 [details] [diff] [review]
WIP patch

The way the platforms are configured, this doesn't enable any desktop tests on try.  Also, the mobile_config.py part of this patch is part of the work for bug 931874.

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/buildbot-configs/rev/5e7078dcbb58

Comment 5

[John Hopkins (:jhopkins)]

in production

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/build/buildbot-configs/rev/31ec4864ebab - this only enabled some of the Cpp tests (debug Mac and Windows, and opt Android, while missing all Linux and opt Mac and Windows), but also enabled Jit tests on Android, which was the one place that we absolutely did not yet want them since they infinitely retry there.

Comment 7

[Dan Minor [:dminor]]

Attachment: Enable cpp unittests on try

This is based on kmoir's patch. I consolidated the opt and debug logic. I removed the checks for Fedora as I don't think they are relevant anymore. I also removed the part that enabled jit-tests for Android.

I'm not able to test this locally, but this should at least partially address the problems philor noted.

Comment 8

[Dan Minor [:dminor]]

Attachment: Enable cpp unittests on try

Sorry, missed the android changes the first time.

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8334521 [details] [diff] [review]
Enable cpp unittests on try

Review of attachment 8334521 [details] [diff] [review]:
-----------------------------------------------------------------

AFAICT, this will end up scheduling cpp tests on both Fedora and EC2 slaves (like the JIT tests on cedar now), which I don't think is what we want; we'll want to keep the "exclude Fedora" logic.

Comment 10

[Dan Minor [:dminor]]

Attachment: Enable cpp unittests on try

Added back in the check for fedora and fedora64. The reporting on tbpl had changed which lead me to believe we didn't need this anymore.

Comment 11

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8335269 [details] [diff] [review]
Enable cpp unittests on try

Review of attachment 8335269 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks.

Comment 12

[Dan Minor [:dminor]]

Thanks, pushed to https://hg.mozilla.org/build/buildbot-configs/rev/261194f39dac

Comment 13

[Justin Wood (:Callek)]

something[s] here made it to production