931961 - tr_process_case.cgi Syntax error at line 221

Status: RESOLVED FIXED

(Testopia :: Test Cases, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

Goto a Test Run (tr_show_run.cgi?run_id=XXX) 

Select a Case in the mid section of the page

In the bottom section click on "Bugs" or "Attachments" 




Actual results:

[Mon Oct 28 00:22:25 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:25 2013] tr_caserun.cgi: Use of uninitialized value in join or string at /loader/0x21798fa8/Bugzilla/Extension/Testopia/TestCaseRun.pm line 920., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: syntax error at /bugzilla/tr_process_case.cgi line 221, near "$field qw(action effect)", referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 222., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 223., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 225., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 227., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 228., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 229., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 230., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 231., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6
[Mon Oct 28 00:22:29 2013] [error] [client xxx.xxx.xxx.xxx] [Mon Oct 28 00:22:29 2013] tr_process_case.cgi: Global symbol "$field" requires explicit package name at /bugzilla/tr_process_case.cgi line 232., referer: http://xxx.xxx.xxx.xxx/tr_show_run.cgi?run_id=6


Expected results:

The bug panel should display not an error panel with the above error.

Comment 1

[[e-mail]]

I was able to fix the error 

Line 221 of the tr_process_case.cgi

--- foreach my $field qw(action effect) {
+++ foreach my $field (qw(action effect)) {

Consider this a hack until confirmed by a real developer =)

Comment 2

[u430950]

Attachment: tr_process_case.cgi.patch

Created a patch with the aforementioned fix. This fix is necessary to restore Testopia function with Bugzilla trunk.

Comment 3

[Frédéric Buclin]

Comment on attachment 8411936 [details] [diff] [review]
tr_process_case.cgi.patch

This is the correct fix. Parens around qw() are mandatory since Perl 5.14, see bug 607966. r=LpSolit

Comment 4

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/extensions/testopia.git
   f536f83..21bc33a  master -> master