931993 - In user info header, translated log-in/log-out button labels can be truncated if too long

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[nicolas m]

Attachment: Truncated “Déconnexion”.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025150754

Steps to reproduce:

(with French, maybe it's or will be the same with other languages)
— Go on webmaker.org ;
— Select French ;
— Look at log-in button, “Connexio(n)” ;
— Log-in ;
— Look at log-out link, “Déconne(xion)” ;


Actual results:

You read “Connexio” and “Déconne” (or small variations according to your zoom settings). It’s furthermore misfit as “Déconne” means something like “acting like a fool”.


Expected results:

You should see the complete words: “Connexion” and “Déconnexion”.

Comment 1

[nicolas m]

The issue is located in the https://login.webmaker.org/css/nav.css file, where two widths are defined for the iframe, one for when logged-out, one when logged-in:

>	#webmaker-nav iframe.include-frame{
>		width:9em;
>	}

>	#webmaker-nav iframe.include-frame.loggedin{
>		width:4em!important
>	}

I wondering if there is a way to always get the right iframe width what ever length the label have inside. We can still do something like:

>	html[lang=fr] #webmaker-nav iframe.include-frame{
>		width: A-LARGER-WIDTH !important
>	}

But this is a quick hack, not easy to maintain, especially if you have to define a specific working width for each language.

Comment 3

[Jon Buckley [:jbuck]]

This was fixed when we landed the new webmaker auth