931998 - Enable MOZ_CONTENT_SANDBOX for XP_UNIX instead of XP_LINUX so it gets included in B2G

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Brian R. Bondy [:bbondy]]

In Bug 922756 I added code for content sandboxing in Windows. This re-used the flag MOZ_CONTENT_SANDBOX.

To ensure that the linux/unix specific bits didn't get compiled on Windows I also added a guard:
> ifdef MOZ_CONTENT_SANDBOX #{
> +ifeq ($(OS_ARCH),Linux)

and 

> #if defined(MOZ_CONTENT_SANDBOX) && defined(XP_LINUX)

(See this changeset: http://hg.mozilla.org/integration/mozilla-inbound/rev/f00c0b788fd7)


After I landed that though I noticed that we want MOZ_CONTENT_SANDBOX on for B2G now:
http://dxr.mozilla.org/mozilla-central/source/configure.in#l6343

I think that OS_ARCH is Linux is defined for b2g, but not XP_LINUX.
On #b2g they said what I want is XP_UNIX.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Comment 2

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99c73ffc83d4

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99c73ffc83d4